Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef COMPONENTS_SYNC_DRIVER_USER_SELECTABLE_SYNC_TYPE_H_ | 5 #ifndef COMPONENTS_SYNC_DRIVER_USER_SELECTABLE_SYNC_TYPE_H_ |
| 6 #define COMPONENTS_SYNC_DRIVER_USER_SELECTABLE_SYNC_TYPE_H_ | 6 #define COMPONENTS_SYNC_DRIVER_USER_SELECTABLE_SYNC_TYPE_H_ |
| 7 | 7 |
| 8 namespace sync_driver { | 8 namespace syncer { |
| 9 namespace user_selectable_type { | 9 namespace user_selectable_type { |
|
skym
2016/09/30 19:03:22
newline
maxbogue
2016/09/30 20:13:41
Acknowledged.
| |
| 10 | 10 |
| 11 // An enumeration of the sync datatypes that are explicitly exposed to the user | 11 // An enumeration of the sync datatypes that are explicitly exposed to the user |
| 12 // via checkboxes in the "Advanced Sync Preferences" dialog. Used solely for the | 12 // via checkboxes in the "Advanced Sync Preferences" dialog. Used solely for the |
| 13 // purposes of UMA histogram logging of the datatypes explicitly selected by | 13 // purposes of UMA histogram logging of the datatypes explicitly selected by |
| 14 // users when sync is configured on a machine. This is a subset of the sync | 14 // users when sync is configured on a machine. This is a subset of the sync |
| 15 // types listed in sync/base/model_type.h. | 15 // types listed in sync/base/model_type.h. |
| 16 // | 16 // |
| 17 // Note: New sync datatypes must be added to the end of this list. Adding them | 17 // Note: New sync datatypes must be added to the end of this list. Adding them |
| 18 // anywhere else will result in incorrect histogram logging. | 18 // anywhere else will result in incorrect histogram logging. |
| 19 | 19 |
| 20 // THIS ENUM IS MEANT SOLELY FOR THE PURPOSE OF HISTOGRAM LOGGING. IF YOU ARE | 20 // THIS ENUM IS MEANT SOLELY FOR THE PURPOSE OF HISTOGRAM LOGGING. IF YOU ARE |
| 21 // LOOKING TO MODIFY SYNC FUNCTIONALITY AND NEED A LIST OF SYNC TYPES, USE | 21 // LOOKING TO MODIFY SYNC FUNCTIONALITY AND NEED A LIST OF SYNC TYPES, USE |
| 22 // syncer::ModelType. | 22 // ModelType. |
|
skym
2016/09/30 19:03:22
Might be good to leave the namespace here.
maxbogue
2016/09/30 20:13:41
Done.
| |
| 23 | 23 |
| 24 enum UserSelectableSyncType { | 24 enum UserSelectableSyncType { |
| 25 BOOKMARKS = 0, | 25 BOOKMARKS = 0, |
| 26 PREFERENCES = 1, | 26 PREFERENCES = 1, |
| 27 PASSWORDS = 2, | 27 PASSWORDS = 2, |
| 28 AUTOFILL = 3, | 28 AUTOFILL = 3, |
| 29 THEMES = 4, | 29 THEMES = 4, |
| 30 TYPED_URLS = 5, | 30 TYPED_URLS = 5, |
| 31 EXTENSIONS = 6, | 31 EXTENSIONS = 6, |
| 32 PROXY_TABS = 7, | 32 PROXY_TABS = 7, |
| (...skipping 25 matching lines...) Expand all Loading... | |
| 58 // ARTICLE, | 58 // ARTICLE, |
| 59 // SYNCED_NOTIFICATION_APP_INFO, | 59 // SYNCED_NOTIFICATION_APP_INFO, |
| 60 // ARC_PACKAGE, | 60 // ARC_PACKAGE, |
| 61 // PRINTERS | 61 // PRINTERS |
| 62 // READING_LIST | 62 // READING_LIST |
| 63 | 63 |
| 64 // Number of sync datatypes exposed to the user via checboxes in the UI. | 64 // Number of sync datatypes exposed to the user via checboxes in the UI. |
| 65 SELECTABLE_DATATYPE_COUNT = 11, | 65 SELECTABLE_DATATYPE_COUNT = 11, |
| 66 }; | 66 }; |
| 67 | 67 |
| 68 } // namespace user_selectable_type | 68 } // namespace user_selectable_type |
|
skym
2016/09/30 19:03:22
newline
maxbogue
2016/09/30 20:13:41
Acknowledged.
| |
| 69 } // namespace sync_driver | 69 } // namespace syncer |
| 70 | 70 |
| 71 #endif // COMPONENTS_SYNC_DRIVER_USER_SELECTABLE_SYNC_TYPE_H_ | 71 #endif // COMPONENTS_SYNC_DRIVER_USER_SELECTABLE_SYNC_TYPE_H_ |
| OLD | NEW |