OLD | NEW |
1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "components/sync/driver/shared_change_processor.h" | 5 #include "components/sync/driver/shared_change_processor.h" |
6 | 6 |
7 #include <memory> | 7 #include <memory> |
8 #include <utility> | 8 #include <utility> |
9 | 9 |
10 #include "base/threading/thread_task_runner_handle.h" | 10 #include "base/threading/thread_task_runner_handle.h" |
11 #include "components/sync/api/data_type_error_handler.h" | 11 #include "components/sync/api/data_type_error_handler.h" |
12 #include "components/sync/api/sync_change.h" | 12 #include "components/sync/api/sync_change.h" |
13 #include "components/sync/api/syncable_service.h" | 13 #include "components/sync/api/syncable_service.h" |
14 #include "components/sync/base/data_type_histogram.h" | 14 #include "components/sync/base/data_type_histogram.h" |
15 #include "components/sync/driver/generic_change_processor.h" | 15 #include "components/sync/driver/generic_change_processor.h" |
16 #include "components/sync/driver/generic_change_processor_factory.h" | 16 #include "components/sync/driver/generic_change_processor_factory.h" |
17 #include "components/sync/driver/shared_change_processor_ref.h" | 17 #include "components/sync/driver/shared_change_processor_ref.h" |
18 #include "components/sync/driver/sync_client.h" | 18 #include "components/sync/driver/sync_client.h" |
19 | 19 |
20 using base::AutoLock; | 20 using base::AutoLock; |
21 | 21 |
22 namespace syncer { | 22 namespace syncer { |
23 class AttachmentService; | 23 class AttachmentService; |
24 } // namespace syncer | 24 } // namespace syncer |
25 | 25 |
26 namespace sync_driver { | 26 namespace syncer { |
27 | 27 |
28 SharedChangeProcessor::SharedChangeProcessor(syncer::ModelType type) | 28 SharedChangeProcessor::SharedChangeProcessor(ModelType type) |
29 : disconnected_(false), | 29 : disconnected_(false), |
30 type_(type), | 30 type_(type), |
31 frontend_task_runner_(base::ThreadTaskRunnerHandle::Get()), | 31 frontend_task_runner_(base::ThreadTaskRunnerHandle::Get()), |
32 generic_change_processor_(NULL) { | 32 generic_change_processor_(NULL) { |
33 DCHECK_NE(type_, syncer::UNSPECIFIED); | 33 DCHECK_NE(type_, UNSPECIFIED); |
34 } | 34 } |
35 | 35 |
36 SharedChangeProcessor::~SharedChangeProcessor() { | 36 SharedChangeProcessor::~SharedChangeProcessor() { |
37 // We can either be deleted when the DTC is destroyed (on UI | 37 // We can either be deleted when the DTC is destroyed (on UI |
38 // thread), or when the syncer::SyncableService stops syncing (datatype | 38 // thread), or when the SyncableService stops syncing (datatype |
39 // thread). |generic_change_processor_|, if non-NULL, must be | 39 // thread). |generic_change_processor_|, if non-NULL, must be |
40 // deleted on |backend_loop_|. | 40 // deleted on |backend_loop_|. |
41 if (backend_task_runner_.get()) { | 41 if (backend_task_runner_.get()) { |
42 if (backend_task_runner_->BelongsToCurrentThread()) { | 42 if (backend_task_runner_->BelongsToCurrentThread()) { |
43 delete generic_change_processor_; | 43 delete generic_change_processor_; |
44 } else { | 44 } else { |
45 DCHECK(frontend_task_runner_->BelongsToCurrentThread()); | 45 DCHECK(frontend_task_runner_->BelongsToCurrentThread()); |
46 if (!backend_task_runner_->DeleteSoon(FROM_HERE, | 46 if (!backend_task_runner_->DeleteSoon(FROM_HERE, |
47 generic_change_processor_)) { | 47 generic_change_processor_)) { |
48 NOTREACHED(); | 48 NOTREACHED(); |
49 } | 49 } |
50 } | 50 } |
51 } else { | 51 } else { |
52 DCHECK(!generic_change_processor_); | 52 DCHECK(!generic_change_processor_); |
53 } | 53 } |
54 } | 54 } |
55 | 55 |
56 void SharedChangeProcessor::StartAssociation( | 56 void SharedChangeProcessor::StartAssociation( |
57 StartDoneCallback start_done, | 57 StartDoneCallback start_done, |
58 SyncClient* const sync_client, | 58 SyncClient* const sync_client, |
59 syncer::UserShare* user_share, | 59 UserShare* user_share, |
60 std::unique_ptr<syncer::DataTypeErrorHandler> error_handler) { | 60 std::unique_ptr<DataTypeErrorHandler> error_handler) { |
61 DCHECK(user_share); | 61 DCHECK(user_share); |
62 syncer::SyncMergeResult local_merge_result(type_); | 62 SyncMergeResult local_merge_result(type_); |
63 syncer::SyncMergeResult syncer_merge_result(type_); | 63 SyncMergeResult syncer_merge_result(type_); |
64 base::WeakPtrFactory<syncer::SyncMergeResult> weak_ptr_factory( | 64 base::WeakPtrFactory<SyncMergeResult> weak_ptr_factory(&syncer_merge_result); |
65 &syncer_merge_result); | |
66 | 65 |
67 // Connect |shared_change_processor| to the syncer and get the | 66 // Connect |shared_change_processor| to the syncer and get the |
68 // syncer::SyncableService associated with type_. | 67 // SyncableService associated with type_. |
69 // Note that it's possible the shared_change_processor has already been | 68 // Note that it's possible the shared_change_processor has already been |
70 // disconnected at this point, so all our accesses to the syncer from this | 69 // disconnected at this point, so all our accesses to the syncer from this |
71 // point on are through it. | 70 // point on are through it. |
72 GenericChangeProcessorFactory factory; | 71 GenericChangeProcessorFactory factory; |
73 local_service_ = | 72 local_service_ = |
74 Connect(sync_client, &factory, user_share, std::move(error_handler), | 73 Connect(sync_client, &factory, user_share, std::move(error_handler), |
75 weak_ptr_factory.GetWeakPtr()); | 74 weak_ptr_factory.GetWeakPtr()); |
76 if (!local_service_.get()) { | 75 if (!local_service_.get()) { |
77 syncer::SyncError error(FROM_HERE, syncer::SyncError::DATATYPE_ERROR, | 76 SyncError error(FROM_HERE, SyncError::DATATYPE_ERROR, |
78 "Failed to connect to syncer.", type_); | 77 "Failed to connect to syncer.", type_); |
79 local_merge_result.set_error(error); | 78 local_merge_result.set_error(error); |
80 start_done.Run(DataTypeController::ASSOCIATION_FAILED, local_merge_result, | 79 start_done.Run(DataTypeController::ASSOCIATION_FAILED, local_merge_result, |
81 syncer_merge_result); | 80 syncer_merge_result); |
82 return; | 81 return; |
83 } | 82 } |
84 | 83 |
85 if (!CryptoReadyIfNecessary()) { | 84 if (!CryptoReadyIfNecessary()) { |
86 syncer::SyncError error(FROM_HERE, syncer::SyncError::CRYPTO_ERROR, "", | 85 SyncError error(FROM_HERE, SyncError::CRYPTO_ERROR, "", type_); |
87 type_); | |
88 local_merge_result.set_error(error); | 86 local_merge_result.set_error(error); |
89 start_done.Run(DataTypeController::NEEDS_CRYPTO, local_merge_result, | 87 start_done.Run(DataTypeController::NEEDS_CRYPTO, local_merge_result, |
90 syncer_merge_result); | 88 syncer_merge_result); |
91 return; | 89 return; |
92 } | 90 } |
93 | 91 |
94 bool sync_has_nodes = false; | 92 bool sync_has_nodes = false; |
95 if (!SyncModelHasUserCreatedNodes(&sync_has_nodes)) { | 93 if (!SyncModelHasUserCreatedNodes(&sync_has_nodes)) { |
96 syncer::SyncError error(FROM_HERE, syncer::SyncError::UNRECOVERABLE_ERROR, | 94 SyncError error(FROM_HERE, SyncError::UNRECOVERABLE_ERROR, |
97 "Failed to load sync nodes", type_); | 95 "Failed to load sync nodes", type_); |
98 local_merge_result.set_error(error); | 96 local_merge_result.set_error(error); |
99 start_done.Run(DataTypeController::UNRECOVERABLE_ERROR, local_merge_result, | 97 start_done.Run(DataTypeController::UNRECOVERABLE_ERROR, local_merge_result, |
100 syncer_merge_result); | 98 syncer_merge_result); |
101 return; | 99 return; |
102 } | 100 } |
103 | 101 |
104 // Scope for |initial_sync_data| which might be expensive, so we don't want | 102 // Scope for |initial_sync_data| which might be expensive, so we don't want |
105 // to keep it in memory longer than necessary. | 103 // to keep it in memory longer than necessary. |
106 { | 104 { |
107 syncer::SyncDataList initial_sync_data; | 105 SyncDataList initial_sync_data; |
108 | 106 |
109 base::TimeTicks start_time = base::TimeTicks::Now(); | 107 base::TimeTicks start_time = base::TimeTicks::Now(); |
110 syncer::SyncError error = | 108 SyncError error = GetAllSyncDataReturnError(type_, &initial_sync_data); |
111 GetAllSyncDataReturnError(type_, &initial_sync_data); | |
112 if (error.IsSet()) { | 109 if (error.IsSet()) { |
113 local_merge_result.set_error(error); | 110 local_merge_result.set_error(error); |
114 start_done.Run(DataTypeController::ASSOCIATION_FAILED, local_merge_result, | 111 start_done.Run(DataTypeController::ASSOCIATION_FAILED, local_merge_result, |
115 syncer_merge_result); | 112 syncer_merge_result); |
116 return; | 113 return; |
117 } | 114 } |
118 | 115 |
119 std::string datatype_context; | 116 std::string datatype_context; |
120 if (GetDataTypeContext(&datatype_context)) { | 117 if (GetDataTypeContext(&datatype_context)) { |
121 local_service_->UpdateDataTypeContext( | 118 local_service_->UpdateDataTypeContext( |
122 type_, syncer::SyncChangeProcessor::NO_REFRESH, datatype_context); | 119 type_, SyncChangeProcessor::NO_REFRESH, datatype_context); |
123 } | 120 } |
124 | 121 |
125 syncer_merge_result.set_num_items_before_association( | 122 syncer_merge_result.set_num_items_before_association( |
126 initial_sync_data.size()); | 123 initial_sync_data.size()); |
127 // Passes a reference to |shared_change_processor|. | 124 // Passes a reference to |shared_change_processor|. |
128 local_merge_result = local_service_->MergeDataAndStartSyncing( | 125 local_merge_result = local_service_->MergeDataAndStartSyncing( |
129 type_, initial_sync_data, std::unique_ptr<syncer::SyncChangeProcessor>( | 126 type_, initial_sync_data, std::unique_ptr<SyncChangeProcessor>( |
130 new SharedChangeProcessorRef(this)), | 127 new SharedChangeProcessorRef(this)), |
131 std::unique_ptr<syncer::SyncErrorFactory>( | 128 std::unique_ptr<SyncErrorFactory>(new SharedChangeProcessorRef(this))); |
132 new SharedChangeProcessorRef(this))); | |
133 RecordAssociationTime(base::TimeTicks::Now() - start_time); | 129 RecordAssociationTime(base::TimeTicks::Now() - start_time); |
134 if (local_merge_result.error().IsSet()) { | 130 if (local_merge_result.error().IsSet()) { |
135 start_done.Run(DataTypeController::ASSOCIATION_FAILED, local_merge_result, | 131 start_done.Run(DataTypeController::ASSOCIATION_FAILED, local_merge_result, |
136 syncer_merge_result); | 132 syncer_merge_result); |
137 return; | 133 return; |
138 } | 134 } |
139 } | 135 } |
140 | 136 |
141 syncer_merge_result.set_num_items_after_association(GetSyncCount()); | 137 syncer_merge_result.set_num_items_after_association(GetSyncCount()); |
142 | 138 |
143 start_done.Run(!sync_has_nodes ? DataTypeController::OK_FIRST_RUN | 139 start_done.Run(!sync_has_nodes ? DataTypeController::OK_FIRST_RUN |
144 : DataTypeController::OK, | 140 : DataTypeController::OK, |
145 local_merge_result, syncer_merge_result); | 141 local_merge_result, syncer_merge_result); |
146 } | 142 } |
147 | 143 |
148 base::WeakPtr<syncer::SyncableService> SharedChangeProcessor::Connect( | 144 base::WeakPtr<SyncableService> SharedChangeProcessor::Connect( |
149 SyncClient* sync_client, | 145 SyncClient* sync_client, |
150 GenericChangeProcessorFactory* processor_factory, | 146 GenericChangeProcessorFactory* processor_factory, |
151 syncer::UserShare* user_share, | 147 UserShare* user_share, |
152 std::unique_ptr<syncer::DataTypeErrorHandler> error_handler, | 148 std::unique_ptr<DataTypeErrorHandler> error_handler, |
153 const base::WeakPtr<syncer::SyncMergeResult>& merge_result) { | 149 const base::WeakPtr<SyncMergeResult>& merge_result) { |
154 DCHECK(sync_client); | 150 DCHECK(sync_client); |
155 DCHECK(error_handler); | 151 DCHECK(error_handler); |
156 backend_task_runner_ = base::ThreadTaskRunnerHandle::Get(); | 152 backend_task_runner_ = base::ThreadTaskRunnerHandle::Get(); |
157 AutoLock lock(monitor_lock_); | 153 AutoLock lock(monitor_lock_); |
158 if (disconnected_) | 154 if (disconnected_) |
159 return base::WeakPtr<syncer::SyncableService>(); | 155 return base::WeakPtr<SyncableService>(); |
160 error_handler_ = std::move(error_handler); | 156 error_handler_ = std::move(error_handler); |
161 base::WeakPtr<syncer::SyncableService> local_service = | 157 base::WeakPtr<SyncableService> local_service = |
162 sync_client->GetSyncableServiceForType(type_); | 158 sync_client->GetSyncableServiceForType(type_); |
163 if (!local_service.get()) { | 159 if (!local_service.get()) { |
164 LOG(WARNING) << "SyncableService destroyed before DTC was stopped."; | 160 LOG(WARNING) << "SyncableService destroyed before DTC was stopped."; |
165 disconnected_ = true; | 161 disconnected_ = true; |
166 return base::WeakPtr<syncer::SyncableService>(); | 162 return base::WeakPtr<SyncableService>(); |
167 } | 163 } |
168 | 164 |
169 generic_change_processor_ = processor_factory | 165 generic_change_processor_ = processor_factory |
170 ->CreateGenericChangeProcessor( | 166 ->CreateGenericChangeProcessor( |
171 type_, user_share, error_handler_->Copy(), | 167 type_, user_share, error_handler_->Copy(), |
172 local_service, merge_result, sync_client) | 168 local_service, merge_result, sync_client) |
173 .release(); | 169 .release(); |
174 // If available, propagate attachment service to the syncable service. | 170 // If available, propagate attachment service to the syncable service. |
175 std::unique_ptr<syncer::AttachmentService> attachment_service = | 171 std::unique_ptr<AttachmentService> attachment_service = |
176 generic_change_processor_->GetAttachmentService(); | 172 generic_change_processor_->GetAttachmentService(); |
177 if (attachment_service) { | 173 if (attachment_service) { |
178 local_service->SetAttachmentService(std::move(attachment_service)); | 174 local_service->SetAttachmentService(std::move(attachment_service)); |
179 } | 175 } |
180 return local_service; | 176 return local_service; |
181 } | 177 } |
182 | 178 |
183 bool SharedChangeProcessor::Disconnect() { | 179 bool SharedChangeProcessor::Disconnect() { |
184 // May be called from any thread. | 180 // May be called from any thread. |
185 DVLOG(1) << "Disconnecting change processor."; | 181 DVLOG(1) << "Disconnecting change processor."; |
(...skipping 12 matching lines...) Expand all Loading... |
198 DCHECK(backend_task_runner_.get()); | 194 DCHECK(backend_task_runner_.get()); |
199 DCHECK(backend_task_runner_->BelongsToCurrentThread()); | 195 DCHECK(backend_task_runner_->BelongsToCurrentThread()); |
200 AutoLock lock(monitor_lock_); | 196 AutoLock lock(monitor_lock_); |
201 if (disconnected_) { | 197 if (disconnected_) { |
202 LOG(ERROR) << "Change processor disconnected."; | 198 LOG(ERROR) << "Change processor disconnected."; |
203 return 0; | 199 return 0; |
204 } | 200 } |
205 return generic_change_processor_->GetSyncCount(); | 201 return generic_change_processor_->GetSyncCount(); |
206 } | 202 } |
207 | 203 |
208 syncer::SyncError SharedChangeProcessor::ProcessSyncChanges( | 204 SyncError SharedChangeProcessor::ProcessSyncChanges( |
209 const tracked_objects::Location& from_here, | 205 const tracked_objects::Location& from_here, |
210 const syncer::SyncChangeList& list_of_changes) { | 206 const SyncChangeList& list_of_changes) { |
211 DCHECK(backend_task_runner_.get()); | 207 DCHECK(backend_task_runner_.get()); |
212 DCHECK(backend_task_runner_->BelongsToCurrentThread()); | 208 DCHECK(backend_task_runner_->BelongsToCurrentThread()); |
213 AutoLock lock(monitor_lock_); | 209 AutoLock lock(monitor_lock_); |
214 if (disconnected_) { | 210 if (disconnected_) { |
215 // The DTC that disconnects us must ensure it posts a StopSyncing task. | 211 // The DTC that disconnects us must ensure it posts a StopSyncing task. |
216 // If we reach this, it means it just hasn't executed yet. | 212 // If we reach this, it means it just hasn't executed yet. |
217 syncer::SyncError error(FROM_HERE, syncer::SyncError::DATATYPE_ERROR, | 213 SyncError error(FROM_HERE, SyncError::DATATYPE_ERROR, |
218 "Change processor disconnected.", type_); | 214 "Change processor disconnected.", type_); |
219 return error; | 215 return error; |
220 } | 216 } |
221 return generic_change_processor_->ProcessSyncChanges(from_here, | 217 return generic_change_processor_->ProcessSyncChanges(from_here, |
222 list_of_changes); | 218 list_of_changes); |
223 } | 219 } |
224 | 220 |
225 syncer::SyncDataList SharedChangeProcessor::GetAllSyncData( | 221 SyncDataList SharedChangeProcessor::GetAllSyncData(ModelType type) const { |
226 syncer::ModelType type) const { | 222 SyncDataList data; |
227 syncer::SyncDataList data; | |
228 GetAllSyncDataReturnError(type, &data); // Handles the disconnect case. | 223 GetAllSyncDataReturnError(type, &data); // Handles the disconnect case. |
229 return data; | 224 return data; |
230 } | 225 } |
231 | 226 |
232 syncer::SyncError SharedChangeProcessor::GetAllSyncDataReturnError( | 227 SyncError SharedChangeProcessor::GetAllSyncDataReturnError( |
233 syncer::ModelType type, | 228 ModelType type, |
234 syncer::SyncDataList* data) const { | 229 SyncDataList* data) const { |
235 DCHECK(backend_task_runner_.get()); | 230 DCHECK(backend_task_runner_.get()); |
236 DCHECK(backend_task_runner_->BelongsToCurrentThread()); | 231 DCHECK(backend_task_runner_->BelongsToCurrentThread()); |
237 AutoLock lock(monitor_lock_); | 232 AutoLock lock(monitor_lock_); |
238 if (disconnected_) { | 233 if (disconnected_) { |
239 syncer::SyncError error(FROM_HERE, syncer::SyncError::DATATYPE_ERROR, | 234 SyncError error(FROM_HERE, SyncError::DATATYPE_ERROR, |
240 "Change processor disconnected.", type_); | 235 "Change processor disconnected.", type_); |
241 return error; | 236 return error; |
242 } | 237 } |
243 return generic_change_processor_->GetAllSyncDataReturnError(data); | 238 return generic_change_processor_->GetAllSyncDataReturnError(data); |
244 } | 239 } |
245 | 240 |
246 syncer::SyncError SharedChangeProcessor::UpdateDataTypeContext( | 241 SyncError SharedChangeProcessor::UpdateDataTypeContext( |
247 syncer::ModelType type, | 242 ModelType type, |
248 syncer::SyncChangeProcessor::ContextRefreshStatus refresh_status, | 243 SyncChangeProcessor::ContextRefreshStatus refresh_status, |
249 const std::string& context) { | 244 const std::string& context) { |
250 DCHECK(backend_task_runner_.get()); | 245 DCHECK(backend_task_runner_.get()); |
251 DCHECK(backend_task_runner_->BelongsToCurrentThread()); | 246 DCHECK(backend_task_runner_->BelongsToCurrentThread()); |
252 AutoLock lock(monitor_lock_); | 247 AutoLock lock(monitor_lock_); |
253 if (disconnected_) { | 248 if (disconnected_) { |
254 syncer::SyncError error(FROM_HERE, syncer::SyncError::DATATYPE_ERROR, | 249 SyncError error(FROM_HERE, SyncError::DATATYPE_ERROR, |
255 "Change processor disconnected.", type_); | 250 "Change processor disconnected.", type_); |
256 return error; | 251 return error; |
257 } | 252 } |
258 return generic_change_processor_->UpdateDataTypeContext(type, refresh_status, | 253 return generic_change_processor_->UpdateDataTypeContext(type, refresh_status, |
259 context); | 254 context); |
260 } | 255 } |
261 | 256 |
262 void SharedChangeProcessor::AddLocalChangeObserver( | 257 void SharedChangeProcessor::AddLocalChangeObserver( |
263 syncer::LocalChangeObserver* observer) { | 258 LocalChangeObserver* observer) { |
264 DCHECK(backend_task_runner_.get()); | 259 DCHECK(backend_task_runner_.get()); |
265 DCHECK(backend_task_runner_->BelongsToCurrentThread()); | 260 DCHECK(backend_task_runner_->BelongsToCurrentThread()); |
266 | 261 |
267 generic_change_processor_->AddLocalChangeObserver(observer); | 262 generic_change_processor_->AddLocalChangeObserver(observer); |
268 } | 263 } |
269 | 264 |
270 void SharedChangeProcessor::RemoveLocalChangeObserver( | 265 void SharedChangeProcessor::RemoveLocalChangeObserver( |
271 syncer::LocalChangeObserver* observer) { | 266 LocalChangeObserver* observer) { |
272 DCHECK(backend_task_runner_.get()); | 267 DCHECK(backend_task_runner_.get()); |
273 DCHECK(backend_task_runner_->BelongsToCurrentThread()); | 268 DCHECK(backend_task_runner_->BelongsToCurrentThread()); |
274 | 269 |
275 generic_change_processor_->RemoveLocalChangeObserver(observer); | 270 generic_change_processor_->RemoveLocalChangeObserver(observer); |
276 } | 271 } |
277 | 272 |
278 bool SharedChangeProcessor::SyncModelHasUserCreatedNodes(bool* has_nodes) { | 273 bool SharedChangeProcessor::SyncModelHasUserCreatedNodes(bool* has_nodes) { |
279 DCHECK(backend_task_runner_.get()); | 274 DCHECK(backend_task_runner_.get()); |
280 DCHECK(backend_task_runner_->BelongsToCurrentThread()); | 275 DCHECK(backend_task_runner_->BelongsToCurrentThread()); |
281 AutoLock lock(monitor_lock_); | 276 AutoLock lock(monitor_lock_); |
(...skipping 19 matching lines...) Expand all Loading... |
301 DCHECK(backend_task_runner_.get()); | 296 DCHECK(backend_task_runner_.get()); |
302 DCHECK(backend_task_runner_->BelongsToCurrentThread()); | 297 DCHECK(backend_task_runner_->BelongsToCurrentThread()); |
303 AutoLock lock(monitor_lock_); | 298 AutoLock lock(monitor_lock_); |
304 if (disconnected_) { | 299 if (disconnected_) { |
305 LOG(ERROR) << "Change processor disconnected."; | 300 LOG(ERROR) << "Change processor disconnected."; |
306 return false; | 301 return false; |
307 } | 302 } |
308 return generic_change_processor_->GetDataTypeContext(context); | 303 return generic_change_processor_->GetDataTypeContext(context); |
309 } | 304 } |
310 | 305 |
311 syncer::SyncError SharedChangeProcessor::CreateAndUploadError( | 306 SyncError SharedChangeProcessor::CreateAndUploadError( |
312 const tracked_objects::Location& location, | 307 const tracked_objects::Location& location, |
313 const std::string& message) { | 308 const std::string& message) { |
314 AutoLock lock(monitor_lock_); | 309 AutoLock lock(monitor_lock_); |
315 if (!disconnected_) { | 310 if (!disconnected_) { |
316 return error_handler_->CreateAndUploadError(location, message, type_); | 311 return error_handler_->CreateAndUploadError(location, message, type_); |
317 } else { | 312 } else { |
318 return syncer::SyncError(location, syncer::SyncError::DATATYPE_ERROR, | 313 return SyncError(location, SyncError::DATATYPE_ERROR, message, type_); |
319 message, type_); | |
320 } | 314 } |
321 } | 315 } |
322 | 316 |
323 void SharedChangeProcessor::RecordAssociationTime(base::TimeDelta time) { | 317 void SharedChangeProcessor::RecordAssociationTime(base::TimeDelta time) { |
324 #define PER_DATA_TYPE_MACRO(type_str) \ | 318 #define PER_DATA_TYPE_MACRO(type_str) \ |
325 UMA_HISTOGRAM_TIMES("Sync." type_str "AssociationTime", time); | 319 UMA_HISTOGRAM_TIMES("Sync." type_str "AssociationTime", time); |
326 SYNC_DATA_TYPE_HISTOGRAM(type_); | 320 SYNC_DATA_TYPE_HISTOGRAM(type_); |
327 #undef PER_DATA_TYPE_MACRO | 321 #undef PER_DATA_TYPE_MACRO |
328 } | 322 } |
329 | 323 |
330 void SharedChangeProcessor::StopLocalService() { | 324 void SharedChangeProcessor::StopLocalService() { |
331 if (local_service_.get()) | 325 if (local_service_.get()) |
332 local_service_->StopSyncing(type_); | 326 local_service_->StopSyncing(type_); |
333 local_service_.reset(); | 327 local_service_.reset(); |
334 } | 328 } |
335 | 329 |
336 } // namespace sync_driver | 330 } // namespace syncer |
OLD | NEW |