[DevTools] Remove sidebar buttons from Quick Source.

third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 60 matching lines @@
     tabbedPane.element.classList.add("navigator-tabbed-pane");
     var navigatorMenuButton = new WebInspector.ToolbarMenuButton(this._populateNavigatorMenu.bind(this), true);
     navigatorMenuButton.setTitle(WebInspector.UIString("More options"));
     tabbedPane.rightToolbar().appendToolbarItem(navigatorMenuButton);
     this.editorView.setSidebarWidget(tabbedPane);
 
     this._sourcesView = new WebInspector.SourcesView();
     this._sourcesView.addEventListener(WebInspector.SourcesView.Events.EditorSelected, this._editorSelected.bind(this));
     this._sourcesView.addEventListener(WebInspector.SourcesView.Events.EditorClosed, this._editorClosed.bind(this));
     this._sourcesView.registerShortcuts(this.registerShortcuts.bind(this));
-    this.editorView.setMainWidget(this._sourcesView);
+
+    this._toggleNavigatorSidebarButton = this.editorView.createShowHideSidebarButton("navigator");
+    this._toggleDebuggerSidebarButton = this._splitWidget.createShowHideSidebarButton("debugger");
+    this._showSourcesViewInPanel();

[lushnikov, 2016/09/28 21:22:49]

you don't need this call

[dgozman, 2016/09/28 23:06:50]

I am worried something below depends on SourcesView being in hierarchy. E.g.
_editorChanged call.

     this._editorChanged(this._sourcesView.currentUISourceCode());
 
     this._threadsSidebarPane = null;
     this._watchSidebarPane = /** @type {!WebInspector.View} */ (WebInspector.viewManager.view("sources.watch"));
     // TODO: Force installing listeners from the model, not the UI.
     self.runtime.sharedInstance(WebInspector.XHRBreakpointsSidebarPane);
     this._callstackPane = self.runtime.sharedInstance(WebInspector.CallStackSidebarPane);
     this._callstackPane.registerShortcuts(this.registerShortcuts.bind(this));
 
-    this._sourcesView.leftToolbar().appendToolbarItem(this.editorView.createShowHideSidebarButton("navigator"));
-    this._toggleDebuggerSidebarButton = this._splitWidget.createShowHideSidebarButton("debugger");
-    this._sourcesView.rightToolbar().appendToolbarItem(this._toggleDebuggerSidebarButton);
-
     WebInspector.moduleSetting("sidebarPosition").addChangeListener(this._updateSidebarPosition.bind(this));
     this._updateSidebarPosition();
 
     this._updateDebuggerButtons();
     this._pauseOnExceptionEnabledChanged();
     WebInspector.moduleSetting("pauseOnExceptionEnabled").addChangeListener(this._pauseOnExceptionEnabledChanged, this);
 
     this._liveLocationPool = new WebInspector.LiveLocationPool();
 
     this._setTarget(WebInspector.context.flavor(WebInspector.Target));
@@ skipping 76 matching lines @@
 
     wasShown: function()
     {
         WebInspector.context.setFlavor(WebInspector.SourcesPanel, this);
         WebInspector.Panel.prototype.wasShown.call(this);
         var wrapper = WebInspector.SourcesPanel.WrapperView._instance;
         if (wrapper && wrapper.isShowing()) {
             WebInspector.inspectorView.setDrawerMinimized(true);
             WebInspector.SourcesPanel.updateResizer(this);
         }
-        this.editorView.setMainWidget(this._sourcesView);
+        this._showSourcesViewInPanel();
     },
 
     willHide: function()
     {
         WebInspector.Panel.prototype.willHide.call(this);
         WebInspector.context.setFlavor(WebInspector.SourcesPanel, null);
         if (WebInspector.SourcesPanel.WrapperView.isShowing()) {
             WebInspector.SourcesPanel.WrapperView._instance._showViewInWrapper();
             WebInspector.inspectorView.setDrawerMinimized(false);
             WebInspector.SourcesPanel.updateResizer(this);
         }
     },
 
+    _showSourcesViewInPanel: function()
+    {
+        this._sourcesView.leftToolbar().removeToolbarItems();
+        this._sourcesView.leftToolbar().appendToolbarItem(this._toggleNavigatorSidebarButton);
+        this._sourcesView.rightToolbar().removeToolbarItems();
+        this._sourcesView.rightToolbar().appendToolbarItem(this._toggleDebuggerSidebarButton);
+        this.editorView.setMainWidget(this._sourcesView);
+    },
+
     /**
      * @override
      * @param {string} locationName
      * @return {?WebInspector.ViewLocation}
      */
     resolveLocation: function(locationName)
     {
         if (locationName === "sources-sidebar")
             return this._sidebarPaneStack;
         else
@@ skipping 1133 matching lines @@
     },
 
     willHide: function()
     {
         WebInspector.inspectorView.setDrawerMinimized(false);
         setImmediate(() => WebInspector.SourcesPanel.updateResizer(WebInspector.SourcesPanel.instance()));
     },
 
     _showViewInWrapper: function()
     {
+        this._view.leftToolbar().removeToolbarItems();
+        this._view.rightToolbar().removeToolbarItems();
         this._view.show(this.element);
     },
 
     __proto__: WebInspector.VBox.prototype
 }
 
 /**
  * @return {boolean}
  */
 WebInspector.SourcesPanel.WrapperView.isShowing = function()
 {
     return !!WebInspector.SourcesPanel.WrapperView._instance && WebInspector.SourcesPanel.WrapperView._instance.isShowing();
 }