Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2376123002: [DevTools] Remove sidebar buttons from Quick Source. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove sidebar buttons from Quick Source. BUG=650550 Committed: https://crrev.com/415fe1cd2eb05dc4c03cdb72bb331a78355c7aa5 Cr-Commit-Position: refs/heads/master@{#421692}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 5 chunks +16 lines, -6 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
dgozman
Could you please take a look?
4 years, 2 months ago (2016-09-28 21:15:18 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2376123002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js (right): https://codereview.chromium.org/2376123002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js#newcode84 third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:84: this._showSourcesViewInPanel(); you don't need this call
4 years, 2 months ago (2016-09-28 21:22:49 UTC) #3
dgozman
https://codereview.chromium.org/2376123002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js (right): https://codereview.chromium.org/2376123002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js#newcode84 third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:84: this._showSourcesViewInPanel(); On 2016/09/28 21:22:49, lushnikov wrote: > you don't ...
4 years, 2 months ago (2016-09-28 23:06:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376123002/1
4 years, 2 months ago (2016-09-28 23:07:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 00:20:14 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 00:26:52 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/415fe1cd2eb05dc4c03cdb72bb331a78355c7aa5
Cr-Commit-Position: refs/heads/master@{#421692}

Powered by Google App Engine
This is Rietveld 408576698