Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 23761002: Merged r16205, r16220, r16237, r16249, r16262, r16269, r16273 into 3.20 branch. (Closed)

Created:
7 years, 3 months ago by Jakob Kummerow
Modified:
7 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Merged r16205, r16220, r16237, r16249, r16262, r16269, r16273 into 3.20 branch. Mark HStringCompareAndBranch as potentially causing GCs. Prevent empty handle dereference in Runtime_InternalNumberFormat. Fix null handle deref in InternalDateFormat Fix a bug in Div when all uses are truncating Fix "Hole" leak in TryBuildConsolidatedElementLoad Never clear debug-stub call ICs. Make a clear distinction between is_debug_stub used everywhere but the debugger, and IsDebugBreak, used by the debugger. Fix deoptimization bug, where recursive call can frighten and confuse the unwitting, simple, poor caveman that is Runtime_NotifyDeoptimized. BUG=chromium:274438, chromium:275467, 274164 R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -121 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/heap.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +11 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/runtime.cc View 10 chunks +58 lines, -48 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/compiler/regress-shared-deopt.js View 1 chunk +31 lines, -11 lines 0 comments Download
A + test/mjsunit/regress/consolidated-holey-load.js View 1 chunk +8 lines, -10 lines 0 comments Download
A + test/mjsunit/regress/debug-prepare-step-in.js View 2 chunks +19 lines, -14 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-274438.js View 1 chunk +7 lines, -14 lines 0 comments Download
M test/mjsunit/shift-for-integer-div.js View 1 chunk +40 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
7 years, 3 months ago (2013-08-29 13:07:00 UTC) #1
Yang
On 2013/08/29 13:07:00, Jakob wrote: rubberstamped lgtm.
7 years, 3 months ago (2013-08-29 13:09:23 UTC) #2
Jakob Kummerow
7 years, 3 months ago (2013-08-29 13:19:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16426 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698