Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1524)

Issue 2376083002: BlobUrlBrowserTest: Add a test exercising blob: URLs from file:// documents.

Created:
4 years, 2 months ago by ncarter (slow)
Modified:
4 years, 1 month ago
Reviewers:
Charlie Reis, alexmos
CC:
chromium-reviews, jam, darin-cc_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BlobUrlBrowserTest: Add a test exercising blob: URLs from file:// documents. Small tweaks and renaming to other tests. BUG=644966 TEST=content_browsertests CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes. #

Patch Set 3 : With fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -24 lines) Patch
M content/browser/blob_storage/blob_url_browsertest.cc View 1 2 3 chunks +70 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 1 chunk +16 lines, -7 lines 0 comments Download
M content/browser/site_instance_impl.cc View 1 2 2 chunks +8 lines, -9 lines 0 comments Download
M content/public/test/browser_test_base.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/test/browser_test_base.cc View 1 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (19 generated)
ncarter (slow)
Charlie, please review
4 years, 2 months ago (2016-09-28 20:27:48 UTC) #4
Charlie Reis
Looks like we learned some things from this! Maybe disable kAllowFileAccessFromFiles and document the surprising ...
4 years, 2 months ago (2016-09-28 22:48:10 UTC) #7
Charlie Reis
[CC dcheng, based on discussion]
4 years, 2 months ago (2016-09-28 22:48:40 UTC) #8
ncarter (slow)
charlie: PTAL alexmos: FYI
4 years, 2 months ago (2016-10-07 21:07:07 UTC) #11
Charlie Reis
4 years, 2 months ago (2016-10-07 21:48:22 UTC) #13
LGTM, though the new LinkToSameOriginFileBlob  test failed in
content_site_isolation_browsertests on linux_chromium_rel_ng.

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

Powered by Google App Engine
This is Rietveld 408576698