Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2376073003: Add tests for resolveRelativeUri() and a workaround. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests for resolveRelativeUri() and a workaround. The actual problem should be fixed in SDKs Uri implementation. https://github.com/dart-lang/sdk/issues/27447 R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3f6afd8cf58c211e5247246d308b21c27434d673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/analyzer/test/generated/utilities_dart_test.dart View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
scheglov
4 years, 2 months ago (2016-09-28 20:16:59 UTC) #1
Paul Berry
lgtm
4 years, 2 months ago (2016-09-28 20:18:20 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 3f6afd8cf58c211e5247246d308b21c27434d673 (presubmit successful).
4 years, 2 months ago (2016-09-28 20:20:32 UTC) #4
Brian Wilkerson
When do we end up resolving a URI against a relative URI? I thought we ...
4 years, 2 months ago (2016-09-29 14:10:53 UTC) #6
Paul Berry
On 2016/09/29 14:10:53, Brian Wilkerson wrote: > When do we end up resolving a URI ...
4 years, 2 months ago (2016-09-29 14:40:39 UTC) #7
Paul Berry
4 years, 2 months ago (2016-09-29 17:13:52 UTC) #8
Message was sent while issue was closed.
On 2016/09/29 14:40:39, Paul Berry wrote:
> On 2016/09/29 14:10:53, Brian Wilkerson wrote:
> > When do we end up resolving a URI against a relative URI? I thought we
always
> > started with an absolute URI.
> 
> For summaries we resolve relative URIs against relative URIs.  It's possible
> that this is unnecessary (some things about URI handling have changed since
the
> initial design of summaries).  I will look into whether it's possible to stop
> doing this.

After further investigation, I believe it is still necessary.  See my comments
on https://github.com/dart-lang/sdk/issues/27447 for a specific example.

Powered by Google App Engine
This is Rietveld 408576698