Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 2376043002: skpbench: use double buffering instead of triple (Closed)

Created:
4 years, 2 months ago by csmartdalton
Modified:
4 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skpbench: use double buffering instead of triple We have no need for our command stream to get more than a couple of frames deep. Any more and we only increase our chances of sporadic flushing and unreliable timings. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2376043002 Committed: https://skia.googlesource.com/skia/+/e038489a743d6c0ab1cb208862c305180815bc8e

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -42 lines) Patch
M tools/skpbench/skpbench.cpp View 1 5 chunks +47 lines, -42 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
csmartdalton
4 years, 2 months ago (2016-09-28 17:47:54 UTC) #4
bsalomon
lgtm
4 years, 2 months ago (2016-09-28 18:52:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376043002/20001
4 years, 2 months ago (2016-09-28 21:10:57 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 21:53:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e038489a743d6c0ab1cb208862c305180815bc8e

Powered by Google App Engine
This is Rietveld 408576698