Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2376033004:
Add isnan() workaround for Intel Mac (Closed)
DescriptionAdd isnan() workaround for Intel Mac
On some Intel drivers (skylake Windows and Mac), calling
function isnan() on highp float will get wrong answer.
This patch work arounds this bug by using an expression
to emulate this GLSL function. Skylake device ids are
referenced from:
https://cgit.freedesktop.org/vaapi/intel-driver/tree/src/i965_pciids.h
BUG=650547
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/9358866a937bc8cb9facb7feb9d087fab355e459
Cr-Commit-Position: refs/heads/master@{#424101}
Patch Set 1 #Patch Set 2 : Add device_id of skylake #Patch Set 3 : Fix nits #Patch Set 4 : Rebase #
Messages
Total messages: 23 (14 generated)
Description was changed from ========== Add isnan() workaround for Intel Mac On some Intel drivers, calling function isnan() on highp float will get wrong answer. This patch work arounds this bug by using an expression to emulate this GLSL function. BUG=650547 ========== to ========== Add isnan() workaround for Intel Mac On some Intel drivers, calling function isnan() on highp float will get wrong answer. This patch work arounds this bug by using an expression to emulate this GLSL function. BUG=650547 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add isnan() workaround for Intel Mac On some Intel drivers, calling function isnan() on highp float will get wrong answer. This patch work arounds this bug by using an expression to emulate this GLSL function. BUG=650547 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add isnan() workaround for Intel Mac On some Intel drivers (skylake Windows and Mac), calling function isnan() on highp float will get wrong answer. This patch work arounds this bug by using an expression to emulate this GLSL function. BUG=650547 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
jiawei.shao@intel.com changed reviewers: + qiankun.miao@intel.com
Description was changed from ========== Add isnan() workaround for Intel Mac On some Intel drivers, calling function isnan() on highp float will get wrong answer. This patch work arounds this bug by using an expression to emulate this GLSL function. BUG=650547 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add isnan() workaround for Intel Mac On some Intel drivers (skylake Windows and Mac), calling function isnan() on highp float will get wrong answer. This patch work arounds this bug by using an expression to emulate this GLSL function. BUG=650547 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
jiawei.shao@intel.com changed reviewers: + qiankun.miao@intel.com
Description was changed from ========== Add isnan() workaround for Intel Mac On some Intel drivers (skylake Windows and Mac), calling function isnan() on highp float will get wrong answer. This patch work arounds this bug by using an expression to emulate this GLSL function. BUG=650547 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add isnan() workaround for Intel Mac On some Intel drivers (skylake Windows and Mac), calling function isnan() on highp float will get wrong answer. This patch work arounds this bug by using an expression to emulate this GLSL function. Device_ids of Skylake are referenced from: https://cgit.freedesktop.org/vaapi/intel-driver/tree/src/i965_pciids.h BUG=650547 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add isnan() workaround for Intel Mac On some Intel drivers (skylake Windows and Mac), calling function isnan() on highp float will get wrong answer. This patch work arounds this bug by using an expression to emulate this GLSL function. Device_ids of Skylake are referenced from: https://cgit.freedesktop.org/vaapi/intel-driver/tree/src/i965_pciids.h BUG=650547 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add isnan() workaround for Intel Mac On some Intel drivers (skylake Windows and Mac), calling function isnan() on highp float will get wrong answer. This patch work arounds this bug by using an expression to emulate this GLSL function. Skylake device ids are referenced from: https://cgit.freedesktop.org/vaapi/intel-driver/tree/src/i965_pciids.h BUG=650547 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
qiankun.miao@intel.com changed reviewers: + kbr@chromium.org, zmo@chromium.org
PTAL
On 2016/09/29 16:26:37, qiankun wrote: > PTAL lgtm
On 2016/09/29 18:07:01, Zhenyao Mo wrote: > On 2016/09/29 16:26:37, qiankun wrote: > > PTAL > > lgtm What about Windows?
On 2016/09/29 18:08:01, Zhenyao Mo wrote: > On 2016/09/29 18:07:01, Zhenyao Mo wrote: > > On 2016/09/29 16:26:37, qiankun wrote: > > > PTAL > > > > lgtm > > What about Windows? The flag has been set in ANGLE on Windows.
The CQ bit was checked by jiawei.shao@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2376033004/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jiawei.shao@intel.com
The CQ bit was checked by jiawei.shao@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add isnan() workaround for Intel Mac On some Intel drivers (skylake Windows and Mac), calling function isnan() on highp float will get wrong answer. This patch work arounds this bug by using an expression to emulate this GLSL function. Skylake device ids are referenced from: https://cgit.freedesktop.org/vaapi/intel-driver/tree/src/i965_pciids.h BUG=650547 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add isnan() workaround for Intel Mac On some Intel drivers (skylake Windows and Mac), calling function isnan() on highp float will get wrong answer. This patch work arounds this bug by using an expression to emulate this GLSL function. Skylake device ids are referenced from: https://cgit.freedesktop.org/vaapi/intel-driver/tree/src/i965_pciids.h BUG=650547 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add isnan() workaround for Intel Mac On some Intel drivers (skylake Windows and Mac), calling function isnan() on highp float will get wrong answer. This patch work arounds this bug by using an expression to emulate this GLSL function. Skylake device ids are referenced from: https://cgit.freedesktop.org/vaapi/intel-driver/tree/src/i965_pciids.h BUG=650547 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add isnan() workaround for Intel Mac On some Intel drivers (skylake Windows and Mac), calling function isnan() on highp float will get wrong answer. This patch work arounds this bug by using an expression to emulate this GLSL function. Skylake device ids are referenced from: https://cgit.freedesktop.org/vaapi/intel-driver/tree/src/i965_pciids.h BUG=650547 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/9358866a937bc8cb9facb7feb9d087fab355e459 Cr-Commit-Position: refs/heads/master@{#424101} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/9358866a937bc8cb9facb7feb9d087fab355e459 Cr-Commit-Position: refs/heads/master@{#424101}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2405773002/ by treib@chromium.org. The reason for reverting is: Seems to have broken NavigatingExtensionPopupBrowserTest.DownloadViaPost on Mac 10.10: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8270. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
