Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2376033002: [turbofan] Properly optimize immutable property loads. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Franzi, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly optimize immutable property loads. When lowering a JSLoadNamed with an immutable own property of a known constant JSObject, we can just constant fold the load during native context specialization, similar to what Crankshaft does in HOptimizedGraphBuilder::BuildLoadNamedField. This way we can also constant-fold stuff like Math.LN2 and friends. R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/def77f4f420f7459d748ba487d739d74a78eb221 Cr-Commit-Position: refs/heads/master@{#39849}

Patch Set 1 #

Patch Set 2 : Now with green bots. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 1 chunk +17 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Benedikt Meurer
4 years, 2 months ago (2016-09-28 17:24:09 UTC) #1
Benedikt Meurer
Hey Jaro, Here's an easy one I spotted in various Kraken benchmarks. Please take a ...
4 years, 2 months ago (2016-09-28 17:25:50 UTC) #4
Franzi
On 2016/09/28 at 17:25:50, bmeurer wrote: > Hey Jaro, > > Here's an easy one ...
4 years, 2 months ago (2016-09-29 06:43:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376033002/40001
4 years, 2 months ago (2016-09-29 06:54:37 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-09-29 06:56:38 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 06:56:50 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/def77f4f420f7459d748ba487d739d74a78eb221
Cr-Commit-Position: refs/heads/master@{#39849}

Powered by Google App Engine
This is Rietveld 408576698