Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: services/video_capture/video_capture_device_proxy_impl.h

Issue 2376013002: [Mojo Video Capture] Move conversions between mojom and media types to a separate file (Closed)
Patch Set: mcasas' comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/video_capture/video_capture_device_proxy_impl.h
diff --git a/services/video_capture/video_capture_device_proxy_impl.h b/services/video_capture/video_capture_device_proxy_impl.h
index 3323a20f101604f65104667776a483233e0f6679..a2233f3053e0d9634924f45b08c30e2b8ce79ed9 100644
--- a/services/video_capture/video_capture_device_proxy_impl.h
+++ b/services/video_capture/video_capture_device_proxy_impl.h
@@ -28,20 +28,6 @@ class VideoCaptureDeviceProxyImpl : public mojom::VideoCaptureDeviceProxy {
void OnClientConnectionErrorOrClose();
- // TODO(chfremer): Consider using Mojo type mapping instead of conversion
- // methods.
- // https://crbug.com/642387
- static media::VideoCaptureFormat ConvertFromMojoToMedia(
- mojom::VideoCaptureFormatPtr format);
- static media::VideoPixelFormat ConvertFromMojoToMedia(
- media::mojom::VideoFormat format);
- static media::VideoPixelStorage ConvertFromMojoToMedia(
- mojom::VideoPixelStorage storage);
- static media::ResolutionChangePolicy ConvertFromMojoToMedia(
- mojom::ResolutionChangePolicy policy);
- static media::PowerLineFrequency ConvertFromMojoToMedia(
- mojom::PowerLineFrequency frequency);
-
private:
std::unique_ptr<media::VideoCaptureDevice> device_;
bool device_running_ = false;
« no previous file with comments | « services/video_capture/mojo_media_conversions.cc ('k') | services/video_capture/video_capture_device_proxy_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698