content/browser/loader/resource_dispatcher_host_impl.cc - Issue 23760004: ChildProcessSecurityPolicy: Port FileAPIMessageFilter to use new checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 23760004: ChildProcessSecurityPolicy: Port FileAPIMessageFilter to use new checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: apply kinuko suggestions on reducing sloc bloat Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/fileapi/fileapi_message_filter.cc ('K') | « content/browser/fileapi/fileapi_message_filter.cc ('k') | content/browser/renderer_host/pepper/pepper_security_helper.h » ('j') | content/browser/renderer_host/pepper/pepper_security_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_dispatcher_host_impl.cc

diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc

index 07d88b18ad3bd5a68d8d8ebb384fcb30245f2e26..6593707253a8be8c87d9f6337c6ab1b44baa6f6a 100644

--- a/content/browser/loader/resource_dispatcher_host_impl.cc

+++ b/content/browser/loader/resource_dispatcher_host_impl.cc

@@ -216,8 +216,7 @@ bool ShouldServiceRequest(int process_type,

}

if (iter->type() == ResourceRequestBody::Element::TYPE_FILE_FILESYSTEM) {

fileapi::FileSystemURL url = file_system_context->CrackURL(iter->url());

- if (!policy->HasPermissionsForFileSystemFile(

- child_id, url, fileapi::kReadFilePermissions)) {

+ if (!policy->CanReadFileSystemFile(child_id, url)) {

NOTREACHED() << "Denied unauthorized upload of "

<< iter->url().spec();

return false;