content/browser/child_process_security_policy_impl.cc - Issue 23760004: ChildProcessSecurityPolicy: Port FileAPIMessageFilter to use new checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/child_process_security_policy_impl.cc

Issue 23760004: ChildProcessSecurityPolicy: Port FileAPIMessageFilter to use new checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: apply kinuko suggestions on reducing sloc bloat Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/child_process_security_policy_impl.h ('k') | content/browser/fileapi/browser_file_system_helper.h » ('j') | content/browser/fileapi/fileapi_message_filter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/child_process_security_policy_impl.cc

diff --git a/content/browser/child_process_security_policy_impl.cc b/content/browser/child_process_security_policy_impl.cc

index 91a74935c53185aa4e7db44c77cd41e9142f0e13..dbda8685d807275b0925a17d650978e6d4fafe8a 100644

--- a/content/browser/child_process_security_policy_impl.cc

+++ b/content/browser/child_process_security_policy_impl.cc

@@ -38,6 +38,7 @@ const int kReadFilePermissions =

const int kWriteFilePermissions =

base::PLATFORM_FILE_OPEN |

base::PLATFORM_FILE_WRITE |

+ base::PLATFORM_FILE_APPEND |

base::PLATFORM_FILE_EXCLUSIVE_WRITE |

base::PLATFORM_FILE_ASYNC |

base::PLATFORM_FILE_WRITE_ATTRIBUTES;

@@ -50,7 +51,7 @@ const int kEnumerateDirectoryPermissions =

base::PLATFORM_FILE_ENUMERATE;

// TODO(tommycli): These flag sets need some work to make more obvious.

-// Why for instance, does Create|Write != Create|Write? http://crbug.com/263150

+// Why for instance, does Create|Write != CreateWrite? http://crbug.com/263150

const int kCreateReadWriteFilePermissions =

kReadFilePermissions |

kWriteFilePermissions |