Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2375983002: Revert of [heap] New heuristics for starting of incremental marking. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] New heuristics for starting of incremental marking. (patchset #9 id:160001 of https://codereview.chromium.org/2364923002/ ) Reason for revert: OOMs in nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/9572 Original issue's description: > [heap] New heuristics for starting of incremental marking. > > The motivation for this patch is to move more marking work to tasks. > This is done by postponing the start of incremental marking until > a marking task is running. > > This patch introduces a soft and a hard limits for incremental marking. > When the soft limit is reached, the marking task is scheduled. > If the hard limit is reached before the task is running, then > incremental marking is started without waiting for the task. > > BUG=chromium:616434 > LOG=NO > > Committed: https://crrev.com/55683ddd2a32e0dfb8df66271fbf53e3618cce9d > Cr-Commit-Position: refs/heads/master@{#39831} TBR=hpayer@chromium.org,ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:616434 Committed: https://crrev.com/a5440d11908d3a096aa570d62a01a9a018b8af48 Cr-Commit-Position: refs/heads/master@{#39833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -93 lines) Patch
M src/heap/heap.h View 5 chunks +15 lines, -19 lines 0 comments Download
M src/heap/heap.cc View 5 chunks +13 lines, -57 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +19 lines, -0 lines 0 comments Download
M src/heap/incremental-marking.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/heap/incremental-marking-job.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +13 lines, -1 line 0 comments Download
M test/cctest/heap/heap-tester.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [heap] New heuristics for starting of incremental marking.
4 years, 2 months ago (2016-09-28 15:19:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375983002/1
4 years, 2 months ago (2016-09-28 15:19:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 15:20:00 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 15:20:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5440d11908d3a096aa570d62a01a9a018b8af48
Cr-Commit-Position: refs/heads/master@{#39833}

Powered by Google App Engine
This is Rietveld 408576698