[regexp] Port RegExp.prototype.exec to TurboFan

src/code-stub-assembler.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stub-assembler.h"
 #include "src/code-factory.h"
 #include "src/frames-inl.h"
 #include "src/frames.h"
 #include "src/ic/handler-configuration.h"
 #include "src/ic/stub-cache.h"
@@ skipping 2211 matching lines @@
     CallRuntime(Runtime::kThrowNotGeneric, context,
                 HeapConstant(factory()->NewStringFromAsciiChecked(method_name,
                                                                   TENURED)));
     Goto(&done_loop);  // Never reached.
   }
 
   Bind(&done_loop);
   return var_value.value();
 }
 
+Node* CodeStubAssembler::ThrowIfNotType(Node* context, Node* value,
+                                        int instance_type,

[Igor Sheludko, 2016/09/29 12:55:29]

Same here.

[jgruber, 2016/09/29 14:40:27]

Done.

+                                        char const* method_name) {
+  Label out(this), throw_exception(this, Label::kDeferred);
+  Variable var_value_map(this, MachineType::PointerRepresentation());

[Igor Sheludko, 2016/09/29 12:55:29]

MachineRepresentation::kTagged

[jgruber, 2016/09/29 14:40:27]

Done.

+
+  GotoIf(WordIsSmi(value), &throw_exception);
+
+  // Load the instance type of the {value}.
+  var_value_map.Bind(LoadMap(value));
+  Node* const value_instance_type = LoadMapInstanceType(var_value_map.value());
+
+  Branch(Word32Equal(value_instance_type, Int32Constant(instance_type)), &out,
+         &throw_exception);
+
+  // The {value} is not a compatible receiver for this method.
+  Bind(&throw_exception);
+  CallRuntime(
+      Runtime::kThrowIncompatibleMethodReceiver, context,
+      HeapConstant(factory()->NewStringFromAsciiChecked(method_name, TENURED)),
+      value);
+  var_value_map.Bind(UndefinedConstant());
+  Goto(&out);  // Never reached.
+
+  Bind(&out);
+  return var_value_map.value();
+}
+
 Node* CodeStubAssembler::StringCharCodeAt(Node* string, Node* index) {
   // Translate the {index} into a Word.
   index = SmiToWord(index);
 
   // We may need to loop in case of cons or sliced strings.
   Variable var_index(this, MachineType::PointerRepresentation());
   Variable var_result(this, MachineRepresentation::kWord32);
   Variable var_string(this, MachineRepresentation::kTagged);
   Variable* loop_vars[] = {&var_index, &var_string};
   Label done_loop(this, &var_result), loop(this, 2, loop_vars);
@@ skipping 87 matching lines @@
         // Check if the {string} is an ExternalString.
         Label if_stringisexternal(this), if_stringisnotexternal(this);
         Branch(Word32Equal(Word32And(string_instance_type,
                                      Int32Constant(kStringRepresentationMask)),
                            Int32Constant(kExternalStringTag)),
                &if_stringisexternal, &if_stringisnotexternal);
 
         Bind(&if_stringisexternal);
         {
           // Check if the {string} is a short external string.
-          Label if_stringisshort(this),
-              if_stringisnotshort(this, Label::kDeferred);
+          Label if_stringisnotshort(this),

[Igor Sheludko, 2016/09/29 12:55:29]

I guess this renaming should be part of substr CL.

[jgruber, 2016/09/29 14:40:27]

How come? It's unrelated to both - I'll just split it out into a separate CL.

[Igor Sheludko, 2016/09/29 15:01:34]

Ok.

+              if_stringisshort(this, Label::kDeferred);
           Branch(Word32Equal(Word32And(string_instance_type,
                                        Int32Constant(kShortExternalStringMask)),
                              Int32Constant(0)),
-                 &if_stringisshort, &if_stringisnotshort);
+                 &if_stringisnotshort, &if_stringisshort);
 
-          Bind(&if_stringisshort);
+          Bind(&if_stringisnotshort);
           {
             // Load the actual resource data from the {string}.
             Node* string_resource_data =
                 LoadObjectField(string, ExternalString::kResourceDataOffset,
                                 MachineType::Pointer());
 
             // Check if the {string} is a TwoByteExternalString or a
             // OneByteExternalString.
             Label if_stringistwobyte(this), if_stringisonebyte(this);
             Branch(Word32Equal(Word32And(string_instance_type,
                                          Int32Constant(kStringEncodingMask)),
                                Int32Constant(kTwoByteStringTag)),
                    &if_stringistwobyte, &if_stringisonebyte);
 
             Bind(&if_stringisonebyte);
             {
               var_result.Bind(
                   Load(MachineType::Uint8(), string_resource_data, index));
               Goto(&done_loop);
             }
 
             Bind(&if_stringistwobyte);
             {
               var_result.Bind(Load(MachineType::Uint16(), string_resource_data,
                                    WordShl(index, IntPtrConstant(1))));
               Goto(&done_loop);
             }
           }
 
-          Bind(&if_stringisnotshort);
+          Bind(&if_stringisshort);
           {
             // The {string} might be compressed, call the runtime.
             var_result.Bind(SmiToWord32(
                 CallRuntime(Runtime::kExternalStringGetChar,
                             NoContextConstant(), string, SmiTag(index))));
             Goto(&done_loop);
           }
         }
 
         Bind(&if_stringisnotexternal);
@@ skipping 3307 matching lines @@
                        Heap::kTheHoleValueRootIndex);
 
   // Store the WeakCell in the feedback vector.
   StoreFixedArrayElement(feedback_vector, slot, cell, UPDATE_WRITE_BARRIER,
                          CodeStubAssembler::SMI_PARAMETERS);
   return cell;
 }
 
 }  // namespace internal
 }  // namespace v8