Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: content/browser/service_worker/embedded_worker_instance.h

Issue 2375943002: Revert of ServiceWorker: Implement StartWorker by using mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_instance.h
diff --git a/content/browser/service_worker/embedded_worker_instance.h b/content/browser/service_worker/embedded_worker_instance.h
index 3e0f83feddf192e07fb2eae5998489a61957a03c..116456b4528ccafdd3f830da61a1b9cce0df1b2f 100644
--- a/content/browser/service_worker/embedded_worker_instance.h
+++ b/content/browser/service_worker/embedded_worker_instance.h
@@ -23,7 +23,6 @@
#include "content/browser/service_worker/embedded_worker_status.h"
#include "content/browser/service_worker/service_worker_metrics.h"
#include "content/common/content_export.h"
-#include "content/common/service_worker/embedded_worker.mojom.h"
#include "content/common/service_worker/service_worker_status_code.h"
#include "content/public/common/console_message_level.h"
#include "url/gurl.h"
@@ -33,6 +32,8 @@
#undef SendMessage
#endif
+struct EmbeddedWorkerMsg_StartWorker_Params;
+
namespace IPC {
class Message;
}
@@ -45,7 +46,6 @@
namespace content {
class EmbeddedWorkerRegistry;
-struct EmbeddedWorkerStartParams;
class MessagePortMessageFilter;
class ServiceWorkerContextCore;
@@ -111,7 +111,7 @@
// started and evaluated, or when an error occurs.
// |params| should be populated with service worker version info needed
// to start the worker.
- void Start(std::unique_ptr<EmbeddedWorkerStartParams> params,
+ void Start(std::unique_ptr<EmbeddedWorkerMsg_StartWorker_Params> params,
const StatusCallback& callback);
// Stops the worker. It is invalid to call this when the worker is
@@ -223,9 +223,6 @@
int worker_devtools_agent_route_id,
bool wait_for_debugger);
- // Sends StartWorker message via Mojo.
- void SendMojoStartWorker(std::unique_ptr<EmbeddedWorkerStartParams> params);
-
// Called back from StartTask after a start worker message is sent.
void OnStartWorkerMessageSent();
@@ -308,12 +305,8 @@
// Current running information.
std::unique_ptr<EmbeddedWorkerInstance::WorkerProcessHandle> process_handle_;
int thread_id_;
-
- // These are connected to the renderer process after OnThreadStarted.
std::unique_ptr<shell::InterfaceRegistry> interface_registry_;
std::unique_ptr<shell::InterfaceProvider> remote_interfaces_;
- // |client_| is used to send messages to the renderer process.
- mojom::EmbeddedWorkerInstanceClientPtr client_;
// Whether devtools is attached or not.
bool devtools_attached_;
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/browser/service_worker/embedded_worker_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698