Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1817)

Unified Diff: content/renderer/service_worker/embedded_worker_dispatcher.cc

Issue 2375943002: Revert of ServiceWorker: Implement StartWorker by using mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/embedded_worker_dispatcher.cc
diff --git a/content/renderer/service_worker/embedded_worker_dispatcher.cc b/content/renderer/service_worker/embedded_worker_dispatcher.cc
index bd496773ee559be58d5c3cfbc84c2478b8ca9e32..ec12c06d5aabc50fc1b1252f4a6cf83eb1d1caba 100644
--- a/content/renderer/service_worker/embedded_worker_dispatcher.cc
+++ b/content/renderer/service_worker/embedded_worker_dispatcher.cc
@@ -10,6 +10,7 @@
#include "base/strings/string16.h"
#include "base/strings/utf_string_conversions.h"
#include "content/child/child_process.h"
+#include "content/child/scoped_child_process_reference.h"
#include "content/child/thread_safe_sender.h"
#include "content/child/worker_thread_registry.h"
#include "content/common/devtools_messages.h"
@@ -26,14 +27,23 @@
namespace content {
-EmbeddedWorkerDispatcher::WorkerWrapper::WorkerWrapper(
- blink::WebEmbeddedWorker* worker,
- int devtools_agent_route_id)
- : worker_(worker),
- dev_tools_agent_(
- new EmbeddedWorkerDevToolsAgent(worker, devtools_agent_route_id)) {}
+// A thin wrapper of WebEmbeddedWorker which also adds and releases process
+// references automatically.
+class EmbeddedWorkerDispatcher::WorkerWrapper {
+ public:
+ WorkerWrapper(blink::WebEmbeddedWorker* worker, int devtools_agent_route_id)
+ : worker_(worker),
+ dev_tools_agent_(
+ new EmbeddedWorkerDevToolsAgent(worker, devtools_agent_route_id)) {}
+ ~WorkerWrapper() {}
-EmbeddedWorkerDispatcher::WorkerWrapper::~WorkerWrapper() {}
+ blink::WebEmbeddedWorker* worker() { return worker_.get(); }
+
+ private:
+ ScopedChildProcessReference process_ref_;
+ std::unique_ptr<blink::WebEmbeddedWorker> worker_;
+ std::unique_ptr<EmbeddedWorkerDevToolsAgent> dev_tools_agent_;
+};
EmbeddedWorkerDispatcher::EmbeddedWorkerDispatcher() : weak_factory_(this) {}
@@ -69,15 +79,35 @@
}
void EmbeddedWorkerDispatcher::OnStartWorker(
- const EmbeddedWorkerStartParams& params) {
+ const EmbeddedWorkerMsg_StartWorker_Params& params) {
DCHECK(!workers_.Lookup(params.embedded_worker_id));
TRACE_EVENT0("ServiceWorker", "EmbeddedWorkerDispatcher::OnStartWorker");
- std::unique_ptr<WorkerWrapper> wrapper = StartWorkerContext(
- params, base::MakeUnique<ServiceWorkerContextClient>(
- params.embedded_worker_id, params.service_worker_version_id,
- params.scope, params.script_url,
- params.worker_devtools_agent_route_id));
- RegisterWorker(params.embedded_worker_id, std::move(wrapper));
+ std::unique_ptr<WorkerWrapper> wrapper(new WorkerWrapper(
+ blink::WebEmbeddedWorker::create(
+ new ServiceWorkerContextClient(params.embedded_worker_id,
+ params.service_worker_version_id,
+ params.scope, params.script_url,
+ params.worker_devtools_agent_route_id),
+ NULL),
+ params.worker_devtools_agent_route_id));
+
+ blink::WebEmbeddedWorkerStartData start_data;
+ start_data.scriptURL = params.script_url;
+ start_data.userAgent = base::UTF8ToUTF16(GetContentClient()->GetUserAgent());
+ start_data.waitForDebuggerMode =
+ params.wait_for_debugger ?
+ blink::WebEmbeddedWorkerStartData::WaitForDebugger :
+ blink::WebEmbeddedWorkerStartData::DontWaitForDebugger;
+ start_data.v8CacheOptions = static_cast<blink::WebSettings::V8CacheOptions>(
+ params.settings.v8_cache_options);
+ start_data.dataSaverEnabled = params.settings.data_saver_enabled;
+ start_data.pauseAfterDownloadMode =
+ params.pause_after_download
+ ? blink::WebEmbeddedWorkerStartData::PauseAfterDownload
+ : blink::WebEmbeddedWorkerStartData::DontPauseAfterDownload;
+
+ wrapper->worker()->startWorkerContext(start_data);
+ workers_.AddWithID(wrapper.release(), params.embedded_worker_id);
}
void EmbeddedWorkerDispatcher::OnStopWorker(int embedded_worker_id) {
@@ -133,37 +163,4 @@
target_level, blink::WebString::fromUTF8(message)));
}
-std::unique_ptr<EmbeddedWorkerDispatcher::WorkerWrapper>
-EmbeddedWorkerDispatcher::StartWorkerContext(
- const EmbeddedWorkerStartParams& params,
- std::unique_ptr<ServiceWorkerContextClient> context_client) {
- std::unique_ptr<WorkerWrapper> wrapper(new WorkerWrapper(
- blink::WebEmbeddedWorker::create(context_client.release(), nullptr),
- params.worker_devtools_agent_route_id));
-
- blink::WebEmbeddedWorkerStartData start_data;
- start_data.scriptURL = params.script_url;
- start_data.userAgent = base::UTF8ToUTF16(GetContentClient()->GetUserAgent());
- start_data.waitForDebuggerMode =
- params.wait_for_debugger
- ? blink::WebEmbeddedWorkerStartData::WaitForDebugger
- : blink::WebEmbeddedWorkerStartData::DontWaitForDebugger;
- start_data.v8CacheOptions = static_cast<blink::WebSettings::V8CacheOptions>(
- params.settings.v8_cache_options);
- start_data.dataSaverEnabled = params.settings.data_saver_enabled;
- start_data.pauseAfterDownloadMode =
- params.pause_after_download
- ? blink::WebEmbeddedWorkerStartData::PauseAfterDownload
- : blink::WebEmbeddedWorkerStartData::DontPauseAfterDownload;
-
- wrapper->worker()->startWorkerContext(start_data);
- return wrapper;
-}
-
-void EmbeddedWorkerDispatcher::RegisterWorker(
- int embedded_worker_id,
- std::unique_ptr<WorkerWrapper> wrapper) {
- workers_.AddWithID(wrapper.release(), embedded_worker_id);
-}
-
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698