Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.h

Issue 2375943002: Revert of ServiceWorker: Implement StartWorker by using mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_test_helper.h
diff --git a/content/browser/service_worker/embedded_worker_test_helper.h b/content/browser/service_worker/embedded_worker_test_helper.h
index 97ec16377256d795e09c3ebb7c891891ae6b1605..88bf11bee43571ba4fb8a2c205c564bd3de553f9 100644
--- a/content/browser/service_worker/embedded_worker_test_helper.h
+++ b/content/browser/service_worker/embedded_worker_test_helper.h
@@ -15,16 +15,14 @@
#include "base/containers/hash_tables.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
-#include "base/optional.h"
-#include "content/common/service_worker/embedded_worker.mojom.h"
#include "ipc/ipc_listener.h"
#include "ipc/ipc_test_sink.h"
-#include "mojo/public/cpp/bindings/binding.h"
#include "services/shell/public/interfaces/interface_provider.mojom.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
class GURL;
+struct EmbeddedWorkerMsg_StartWorker_Params;
struct ServiceWorkerMsg_ExtendableMessageEvent_Params;
namespace shell {
@@ -41,7 +39,6 @@
class ServiceWorkerContextCore;
class ServiceWorkerContextWrapper;
class TestBrowserContext;
-struct EmbeddedWorkerStartParams;
struct PushEventPayload;
struct ServiceWorkerFetchRequest;
@@ -63,28 +60,6 @@
class EmbeddedWorkerTestHelper : public IPC::Sender,
public IPC::Listener {
public:
- class MockEmbeddedWorkerInstanceClient
- : public mojom::EmbeddedWorkerInstanceClient {
- public:
- explicit MockEmbeddedWorkerInstanceClient(
- base::WeakPtr<EmbeddedWorkerTestHelper> helper);
- ~MockEmbeddedWorkerInstanceClient() override;
-
- static void Bind(const base::WeakPtr<EmbeddedWorkerTestHelper>& helper,
- mojom::EmbeddedWorkerInstanceClientRequest request);
-
- private:
- // Implementation of mojo interfaces.
- void StartWorker(const EmbeddedWorkerStartParams& params) override;
-
- base::WeakPtr<EmbeddedWorkerTestHelper> helper_;
- mojo::Binding<mojom::EmbeddedWorkerInstanceClient> binding_;
-
- base::Optional<int> embedded_worker_id_;
-
- DISALLOW_COPY_AND_ASSIGN(MockEmbeddedWorkerInstanceClient);
- };
-
// If |user_data_directory| is empty, the context makes storage stuff in
// memory.
explicit EmbeddedWorkerTestHelper(const base::FilePath& user_data_directory);
@@ -105,11 +80,6 @@
// Inner IPC sink for script context messages sent via EmbeddedWorker.
IPC::TestSink* inner_ipc_sink() { return &inner_sink_; }
- std::vector<std::unique_ptr<MockEmbeddedWorkerInstanceClient>>*
- mock_instance_clients() {
- return &mock_instance_clients_;
- }
-
ServiceWorkerContextCore* context();
ServiceWorkerContextWrapper* context_wrapper() { return wrapper_.get(); }
void ShutdownContext();
@@ -125,8 +95,9 @@
return embedded_worker_id_service_worker_version_id_map_;
}
- // Only used for tests that force creating a new render process.
- int new_render_process_id() const { return new_mock_render_process_id_; }
+ // Only used for tests that force creating a new render process. There is no
+ // corresponding MockRenderProcessHost.
+ int new_render_process_id() const { return mock_render_process_id_ + 1; }
TestBrowserContext* browser_context() { return browser_context_.get(); }
@@ -187,7 +158,7 @@
class MockEmbeddedWorkerSetup;
- void OnStartWorkerStub(const EmbeddedWorkerStartParams& params);
+ void OnStartWorkerStub(const EmbeddedWorkerMsg_StartWorker_Params& params);
void OnResumeAfterDownloadStub(int embedded_worker_id);
void OnStopWorkerStub(int embedded_worker_id);
void OnMessageToWorkerStub(int thread_id,
@@ -208,29 +179,18 @@
MessagePortMessageFilter* NewMessagePortMessageFilter();
- std::unique_ptr<shell::InterfaceRegistry> CreateInterfaceRegistry(
- MockRenderProcessHost* rph);
-
std::unique_ptr<TestBrowserContext> browser_context_;
std::unique_ptr<MockRenderProcessHost> render_process_host_;
- std::unique_ptr<MockRenderProcessHost> new_render_process_host_;
scoped_refptr<ServiceWorkerContextWrapper> wrapper_;
IPC::TestSink sink_;
IPC::TestSink inner_sink_;
- std::vector<std::unique_ptr<MockEmbeddedWorkerInstanceClient>>
- mock_instance_clients_;
- size_t mock_instance_clients_next_index_;
-
int next_thread_id_;
int mock_render_process_id_;
- int new_mock_render_process_id_;
std::unique_ptr<shell::InterfaceRegistry> render_process_interface_registry_;
- std::unique_ptr<shell::InterfaceRegistry>
- new_render_process_interface_registry_;
std::map<int, int64_t> embedded_worker_id_service_worker_version_id_map_;

Powered by Google App Engine
This is Rietveld 408576698