ui/views/cocoa/bridged_native_widget.mm - Issue 2375903002: Emit OnNativeWidgetDestroying() before clearing the NSWindowDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/cocoa/bridged_native_widget.mm

Issue 2375903002: Emit OnNativeWidgetDestroying() before clearing the NSWindowDelegate. (Closed)

Patch Set: Add comment Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/cocoa/bridged_native_widget.mm

diff --git a/ui/views/cocoa/bridged_native_widget.mm b/ui/views/cocoa/bridged_native_widget.mm

index b0ab01429cdce334feb89a25766c3dd61b38532a..1ddac6e27c2db91fec37f08e7134a3a64904b959 100644

--- a/ui/views/cocoa/bridged_native_widget.mm

+++ b/ui/views/cocoa/bridged_native_widget.mm

@@ -707,8 +707,10 @@ NSComparisonResult SubviewSorter(NSViewComparatorValue lhs,

parent_->RemoveChildWindow(this);

parent_ = nullptr;

}

- [window_ setDelegate:nil];

[[NSNotificationCenter defaultCenter] removeObserver:window_delegate_];

+ // Note this also clears the NSWindow delegate, after informing Widget

+ // delegates about the closure. NativeWidgetMac then deletes |this| before

+ // returning.

native_widget_mac_->OnWindowWillClose();

}

« no previous file with comments | « no previous file | ui/views/widget/native_widget_mac.mm » ('j') | no next file with comments »