ui/views/widget/native_widget_mac.mm - Issue 2375903002: Emit OnNativeWidgetDestroying() before clearing the NSWindowDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/native_widget_mac.mm

Issue 2375903002: Emit OnNativeWidgetDestroying() before clearing the NSWindowDelegate. (Closed)

Patch Set: Move reseting NSWindow delegate to NativeWidgetMac Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/widget/native_widget_mac.mm

diff --git a/ui/views/widget/native_widget_mac.mm b/ui/views/widget/native_widget_mac.mm

index b1e67e8c5da32d7b029525e910ca24ec9524f40e..40ce9b943eb3ccb8833d131372bc1e057bb0eed6 100644

--- a/ui/views/widget/native_widget_mac.mm

+++ b/ui/views/widget/native_widget_mac.mm

@@ -106,6 +106,7 @@ NSInteger StyleMaskForParams(const Widget::InitParams& params) {

// is still a valid pointer, then reset it.

if (bridge_) {

delegate_->OnNativeWidgetDestroying();

+ [GetNativeWindow() setDelegate:nil];

bridge_.reset();

}

delegate_->OnNativeWidgetDestroyed();