Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/wasm_llvm.expected/linux.json

Issue 2375843005: Stop redirect stdout/stderr and remove close_fds=True (Closed)
Patch Set: add comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py ('K') | « scripts/slave/recipes/chromium_codesearch.expected/full_Chromium_Linux_Codesearch_Builder.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/wasm_llvm.expected/linux.json
diff --git a/scripts/slave/recipes/wasm_llvm.expected/linux.json b/scripts/slave/recipes/wasm_llvm.expected/linux.json
index 5cb4b9a51f42de72a7f65dea09b91e28cb09adc5..065d1e822a6b47622320ce704d1dce30468a2d28 100644
--- a/scripts/slave/recipes/wasm_llvm.expected/linux.json
+++ b/scripts/slave/recipes/wasm_llvm.expected/linux.json
@@ -126,13 +126,14 @@
"RECIPE_MODULE[build::goma]/resources/cloudtail_utils.py",
"start",
"--cloudtail-path",
- "[CACHE]/cipd/goma/cloudtail"
+ "[CACHE]/cipd/goma/cloudtail",
+ "--pid-file",
+ "[TMP_BASE]/cloudtail.pid"
],
"env": {
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"
},
- "name": "start cloudtail",
- "stdout": "/path/to/tmp/"
+ "name": "start cloudtail"
},
{
"allow_subannotations": true,
@@ -216,8 +217,8 @@
"-u",
"RECIPE_MODULE[build::goma]/resources/cloudtail_utils.py",
"stop",
- "--killed-pid",
- "12345"
+ "--killed-pid-file",
+ "[TMP_BASE]/cloudtail.pid"
],
"name": "stop cloudtail"
},
« scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py ('K') | « scripts/slave/recipes/chromium_codesearch.expected/full_Chromium_Linux_Codesearch_Builder.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698