scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json - Issue 2375843005: Stop redirect stdout/stderr and remove close_fds=True

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json

Issue 2375843005: Stop redirect stdout/stderr and remove close_fds=True (Closed)

Patch Set: add comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/goma/example.expected/mac.json ('k') | scripts/slave/recipe_modules/goma/example.expected/win.json » ('j') | scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json

diff --git a/scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json b/scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json

index 5f11fbaa6d18e4ec8fc821f064dc460e84818e08..934cc97ac2764eafe9d8aa882696ae8a0de133c3 100644

--- a/scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json

+++ b/scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json

@@ -87,15 +87,16 @@

"RECIPE_MODULE[build::goma]/resources/cloudtail_utils.py",

"start",

"--cloudtail-path",

- "[CACHE]/cipd/goma/cloudtail"

+ "[CACHE]/cipd/goma/cloudtail",

+ "--pid-file",

+ "[TMP_BASE]/cloudtail.pid"

"env": {

"GOMACTL_CRASH_REPORT_ID_FILE": "build_data_dir/crash_report_id_file",

"GOMA_DUMP_STATS_FILE": "build_data_dir/goma_stats_proto",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

- "name": "start cloudtail",

- "stdout": "/path/to/tmp/"

+ "name": "start cloudtail"

{

"cmd": [

@@ -225,8 +226,8 @@

"-u",

"RECIPE_MODULE[build::goma]/resources/cloudtail_utils.py",

"stop",

- "--killed-pid",

- "12345"

+ "--killed-pid-file",

+ "[TMP_BASE]/cloudtail.pid"

"name": "stop cloudtail"