scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py - Issue 2375843005: Stop redirect stdout/stderr and remove close_fds=True

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py

Issue 2375843005: Stop redirect stdout/stderr and remove close_fds=True (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py

diff --git a/scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py b/scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py

index ea3c619976c857f27e66c2cefcae7b6e454e78dc..413462a4b7889c204fee2acbd12353e2cc35166f 100644

--- a/scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py

+++ b/scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py

@@ -21,8 +21,6 @@ def start_cloudtail(args):

'--log-id', 'goma_compiler_proxy',

'--path',

goma_utils.GetLatestGomaCompilerProxyInfo()],

- stdout=open(os.devnull, 'w'),

- stderr=open(os.devnull, 'w'),

shinyak 2016/09/29 05:00:16 It looks cloudtail emits error to stderr :-( Is it

close_fds=True)

ukai 2016/09/29 04:51:45 might be better to leave stdout, stderr and drop c

tikuta 2016/09/29 05:00:28 raw_io opens fds in goma module. so, I need to clo

sys.stdout.write(str(proc.pid))

« no previous file with comments | « no previous file | no next file » | no next file with comments »