Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 237583016: Remove some dead code in dom/ (Closed)

Created:
6 years, 8 months ago by Inactive
Modified:
6 years, 8 months ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis, yosin_UTC9
Visibility:
Public.

Description

Remove some dead code in dom/ Remove some dead code in dom/. Several functions were defined but never used. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -79 lines) Patch
M Source/core/dom/DOMException.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DOMException.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/dom/DOMImplementation.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/DocumentMarkerController.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentMarkerController.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/dom/Position.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Position.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M Source/core/dom/Range.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Range.cpp View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 8 months ago (2014-04-17 15:14:52 UTC) #1
eseidel
lgtm I wonder when the Position code died.
6 years, 8 months ago (2014-04-17 15:46:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/237583016/1
6 years, 8 months ago (2014-04-17 15:46:30 UTC) #3
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 17:24:15 UTC) #4
Message was sent while issue was closed.
Change committed as 171870

Powered by Google App Engine
This is Rietveld 408576698