Delete the property returned by SelectionNotify as per ICCCM spec

Section 2.4 of the ICCCM spec requires: "The requestor must delete the property named in the SelectionNotify once all the data has been retrieved."
Make Chrome follow this requirement. This has the side effect of allowing pasting into Chrome while Synergy is running

BUG=363293
TEST=Manual, see bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264254

[pkotwicz, 2014-04-15 02:56:07]

sadrul@, PTAL

I think that we can probably get away with not deleting the property in some of
the error cases but I am trying to be overly cautious.

[sadrul, 2014-04-15 16:20:15]

+erg@

https://codereview.chromium.org/237583003/diff/80001/ui/base/x/selection_requ...
File ui/base/x/selection_requestor.cc (right):

https://codereview.chromium.org/237583003/diff/80001/ui/base/x/selection_requ...
ui/base/x/selection_requestor.cc:79: XDeleteProperty(x_display_, x_window_,
pending_request.returned_property);
Should this be inside the if? and/or, should this check that returned_property
is not None?

[pkotwicz, 2014-04-15 16:57:55]

https://codereview.chromium.org/237583003/diff/80001/ui/base/x/selection_requ...
File ui/base/x/selection_requestor.cc (right):

https://codereview.chromium.org/237583003/diff/80001/ui/base/x/selection_requ...
ui/base/x/selection_requestor.cc:79: XDeleteProperty(x_display_, x_window_,
pending_request.returned_property);
I checked and XDeleteProperty() does not do anything bad if returned_property is
None

[sadrul, 2014-04-15 18:04:30]

https://codereview.chromium.org/237583003/diff/80001/ui/base/x/selection_requ...
File ui/base/x/selection_requestor.cc (right):

https://codereview.chromium.org/237583003/diff/80001/ui/base/x/selection_requ...
ui/base/x/selection_requestor.cc:79: XDeleteProperty(x_display_, x_window_,
pending_request.returned_property);
On 2014/04/15 16:57:55, pkotwicz wrote:
> I checked and XDeleteProperty() does not do anything bad if returned_property
is
> None

The man page claims XDeleteProperty can generate BadAtom errors. So I would add
a check for None

[Elliot Glaysher, 2014-04-15 18:16:48]

lgtm

[pkotwicz, 2014-04-15 21:02:57]

Sadrul, can you please take another look?

[sadrul, 2014-04-16 01:53:25]

lgtm

[pkotwicz, 2014-04-16 15:29:23]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-04-16 15:29:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/237583003/100001

[commit-bot: I haz the power, 2014-04-16 18:26:04]

Change committed as 264254