Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/gyp/find_mac_gcc_version.py

Issue 23757062: fixes for Xcode 5 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/find_mac_gcc_version.py
diff --git a/tools/gyp/find_mac_gcc_version.py b/tools/gyp/find_mac_gcc_version.py
index 1f136ddce8eb62dcb13c192309c4a94f7c4958a0..059838086ec2fa53fd3b293c53b6931623749d7d 100755
--- a/tools/gyp/find_mac_gcc_version.py
+++ b/tools/gyp/find_mac_gcc_version.py
@@ -25,11 +25,11 @@ def main():
return '4.2'
elif major == 4 and minor < 5:
return 'com.apple.compilers.llvmgcc42'
- elif major == 4 and minor >= 5:
+ elif (major == 4 and minor >= 5) or major == 5:
# XCode seems to select the specific clang version automatically
return 'com.apple.compilers.llvm.clang.1_0'
else:
- raise Exception('Unknown XCode Version "%s"' % version_match)
+ raise Exception('Unknown XCode Version "%s"' % stdout)
else:
raise Exception('Could not parse output of xcodebuild "%s"' % stdout)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698