tools/perf/measurements/smoothness.py - Issue 23757054: telemetry: Add 'webkit' category back to smoothness benchmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/smoothness.py

Issue 23757054: telemetry: Add 'webkit' category back to smoothness benchmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comment to remove 'webkit' category later. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/smoothness.py

diff --git a/tools/perf/measurements/smoothness.py b/tools/perf/measurements/smoothness.py

index f44feefc08ee82a70400ffbf1a721ac14d81bfe6..079902f07f0bf48bea53eba4b5c9f4b2bfd37213 100644

--- a/tools/perf/measurements/smoothness.py

+++ b/tools/perf/measurements/smoothness.py

@@ -44,7 +44,9 @@ class Smoothness(page_measurement.PageMeasurement):

return hasattr(page, 'smoothness')

def WillRunAction(self, page, tab, action):

- tab.browser.StartTracing('webkit.console,benchmark', 60)

+ # TODO(ermst): Remove "webkit" category after Blink r157377 is picked up by

+ # the reference builds.

+ tab.browser.StartTracing('webkit,webkit.console,benchmark', 60)

if tab.browser.platform.IsRawDisplayFrameRateSupported():

tab.browser.platform.StartRawDisplayFrameRateMeasurement()

self._metrics = smoothness.SmoothnessMetrics(tab)

« no previous file with comments | « no previous file | no next file » | no next file with comments »