Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 23757050: Add scheib as extensions/apps team owner. (Closed)

Created:
7 years, 3 months ago by scheib
Modified:
7 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, asargent_no_longer_on_chrome
Visibility:
Public.

Description

Add scheib as extensions/apps team owner. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223464

Patch Set 1 #

Patch Set 2 : randomized owners lists. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -50 lines) Patch
M chrome/browser/chromeos/extensions/OWNERS View 1 2 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/extensions/OWNERS View 1 1 chunk +21 lines, -15 lines 0 comments Download
M chrome/common/extensions/OWNERS View 1 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/OWNERS View 1 1 chunk +11 lines, -8 lines 0 comments Download
M chrome/renderer/resources/extensions/OWNERS View 1 1 chunk +10 lines, -8 lines 0 comments Download
M extensions/OWNERS View 1 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scheib
7 years, 3 months ago (2013-09-16 18:25:51 UTC) #1
miket_OOO
On 2013/09/16 18:25:51, scheib wrote: LGTM but first: after discussion Antony and I are trying ...
7 years, 3 months ago (2013-09-16 18:38:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/23757050/5001
7 years, 3 months ago (2013-09-16 20:51:01 UTC) #3
commit-bot: I haz the power
Change committed as 223464
7 years, 3 months ago (2013-09-16 23:19:11 UTC) #4
not at google - send to devlin
if it really is the alphabetical thing then perhaps let dpranke@ know, I think he ...
7 years, 3 months ago (2013-09-17 20:15:34 UTC) #5
scheib
Owners suggestion is undergoing iteration, an interactive tool is nearly done: https://codereview.chromium.org/12712002/ After that lands, ...
7 years, 3 months ago (2013-09-17 20:22:29 UTC) #6
miket_OOO
7 years, 3 months ago (2013-09-17 20:25:58 UTC) #7
Oh, neato, so we're not the only ones having this issue. Great, still LGTM.

On Tue, Sep 17, 2013 at 1:21 PM, Vincent Scheib <scheib@chromium.org> wrote:
> Owners suggestion is undergoing iteration, an interactive tool is nearly
> done: https://codereview.chromium.org/12712002/
>
> After that lands, I agree it would be cleaner to randomize the script vs the
> files.
>
>
> On Tue, Sep 17, 2013 at 1:15 PM, <kalman@chromium.org> wrote:
>>
>> if it really is the alphabetical thing then perhaps let dpranke@ know, I
>> think
>> he wrote the reviewer suggestion stuff.
>>
>> https://codereview.chromium.org/23757050/
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Extensions reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to extensions-reviews+unsubscribe@chromium.org.
> To view this discussion on the web visit
>
https://groups.google.com/a/chromium.org/d/msgid/extensions-reviews/CAK-EfXmX....

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698