Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3140)

Unified Diff: base/test/test_launcher.h

Issue 23757033: GTTF: Support running browser tests in parallel (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/test_launcher.h
diff --git a/base/test/test_launcher.h b/base/test/test_launcher.h
index 739cbdd19a04e339eb590e787e81d386db6d87c4..fac72972a816638e8e7bfc277b7d2976a661c90e 100644
--- a/base/test/test_launcher.h
+++ b/base/test/test_launcher.h
@@ -68,6 +68,15 @@ struct TestResult {
// which tests and how are run.
class TestLauncherDelegate {
public:
+ // Called to get a test name for filtering purposes. Usually it's
+ // test case's name and test's name joined by a dot (e.g.
+ // "TestCaseName.TestName").
+ // TODO(phajdan.jr): Remove after transitioning away from run_test_cases.py,
+ // http://crbug.com/236893 .
+ virtual std::string GetTestNameForFiltering(
+ const testing::TestCase* test_case,
+ const testing::TestInfo* test_info) = 0;
+
// Called before a test is considered for running. If it returns false,
// the test is not run. If it returns true, the test will be run provided
// it is part of the current shard.
@@ -91,6 +100,11 @@ class TestLauncherDelegate {
virtual ~TestLauncherDelegate();
};
+// If |result| is not successful, prints that test's failure message
+// (extracted from |full_output|) to stdout.
+void PrintTestOutputSnippetOnFailure(const TestResult& result,
+ const std::string& full_output);
+
// Launches a child process (assumed to be gtest-based binary)
// using |command_line|. If |wrapper| is not empty, it is prepended
// to the final command line. If the child process is still running

Powered by Google App Engine
This is Rietveld 408576698