Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 23757028: Committing unreviewed GM expectations generated by r11087: scaled_tilemode_*, scaled_tilemodes_* (Closed)

Created:
7 years, 3 months ago by epoger
Modified:
6 years, 10 months ago
Reviewers:
humper, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Committing unreviewed GM expectations generated by r11087: scaled_tilemode_*, scaled_tilemodes_* BUG=skia:1603 TBR=humper Committed: https://code.google.com/p/skia/source/detail?r=11164

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8040 lines, -0 lines) Patch
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 1 chunk +192 lines, -0 lines 1 comment Download
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 1 chunk +192 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json View 1 chunk +144 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Release/expected-results.json View 1 chunk +144 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 1 chunk +192 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 1 chunk +192 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json View 1 chunk +144 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Release/expected-results.json View 1 chunk +144 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json View 1 chunk +144 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 1 chunk +144 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json View 1 chunk +144 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json View 1 chunk +144 lines, -0 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json View 1 chunk +96 lines, -0 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 1 chunk +96 lines, -0 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json View 1 chunk +96 lines, -0 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Release/expected-results.json View 1 chunk +96 lines, -0 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Debug/expected-results.json View 1 chunk +96 lines, -0 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Release/expected-results.json View 1 chunk +96 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 chunk +240 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +216 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 chunk +240 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 chunk +228 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 chunk +240 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +228 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 chunk +240 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 chunk +228 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 chunk +240 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +228 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 chunk +240 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 chunk +240 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Debug/expected-results.json View 1 chunk +192 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Release/expected-results.json View 1 chunk +192 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Debug/expected-results.json View 1 chunk +192 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release/expected-results.json View 1 chunk +192 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-NoGPU-x86_64-Debug/expected-results.json View 1 chunk +144 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 1 chunk +192 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 1 chunk +240 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json View 1 chunk +192 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 1 chunk +192 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 1 chunk +240 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite/expected-results.json View 1 chunk +192 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 1 chunk +192 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 1 chunk +192 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 1 chunk +192 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
https://codereview.chromium.org/23757028/diff/1/expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json File expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json (right): https://codereview.chromium.org/23757028/diff/1/expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json#newcode5359 expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json:5359: "scaled_tilemode_bitmap_565.png": { How I created this CL: 1. Make ...
7 years, 3 months ago (2013-09-09 18:12:22 UTC) #1
epoger
Committing TBR, hope you don't mind, Greg...
7 years, 3 months ago (2013-09-09 18:12:59 UTC) #2
epoger
Committed patchset #1 manually as r11164 (presubmit successful).
7 years, 3 months ago (2013-09-09 18:14:06 UTC) #3
epoger
Sorry, Brian, I should have notified you of this as I committed it. Since it ...
7 years, 3 months ago (2013-09-09 19:20:19 UTC) #4
humper
6 years, 10 months ago (2014-01-30 18:03:16 UTC) #5
On 2013/09/09 19:20:19, epoger wrote:
> Sorry, Brian, I should have notified you of this as I committed it.
> 
> Since it only affects scaled_tilemode_* and scaled_tilemodes_* entries, it
> should not interfere with your rebaselines.

lgtm

Powered by Google App Engine
This is Rietveld 408576698