Issue 23757017: remove Isolate::Current from most files starting with 'o' through 'r'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23757017: remove Isolate::Current from most files starting with 'o' through 'r' (Closed)

Created:
7 years, 3 months ago by dcarney

Modified:
7 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

remove Isolate::Current from most files starting with 'o' through 'r' R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16513

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -152 lines)			Patch
M	src/api.cc	View		3 chunks	+6 lines, -5 lines	0 comments	Download
M	src/builtins.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/execution.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/factory.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ic.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/json-stringifier.h	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/liveedit.cc	View		9 chunks	+23 lines, -12 lines	0 comments	Download
M	src/log.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	1	3 chunks	+12 lines, -7 lines	0 comments	Download
M	src/objects.cc	View	1	13 chunks	+23 lines, -33 lines	0 comments	Download
M	src/objects-debug.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-inl.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/parser.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/parser.cc	View		4 chunks	+7 lines, -6 lines	0 comments	Download
M	src/runtime.cc	View		10 chunks	+12 lines, -11 lines	0 comments	Download
M	test/cctest/test-api.cc	View		12 chunks	+51 lines, -50 lines	0 comments	Download
M	test/cctest/test-heap.cc	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit. https://chromiumcodereview.appspot.com/23757017/diff/1/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/23757017/diff/1/src/objects.cc#newcode423 src/objects.cc:423: Handle<Name> name) { A name ...

7 years, 3 months ago (2013-09-03 13:38:53 UTC) #2

dcarney

7 years, 3 months ago (2013-09-04 07:05:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16513 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23757017: remove Isolate::Current from most files starting with 'o' through 'r' (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages