Simplify compilation of relational operators.

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/dart_entry.h"
@@ skipping 905 matching lines @@
     locs->set_out(Location::RequiresRegister());
     return locs;
   }
   if (operation_cid() == kDoubleCid) {
     LocationSummary* summary =
         new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
     summary->set_in(0, Location::RequiresFpuRegister());
     summary->set_in(1, Location::RequiresFpuRegister());
     summary->set_out(Location::RequiresRegister());
     return summary;
-  } else if (operation_cid() == kSmiCid) {
-    LocationSummary* summary =
-        new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
-    summary->set_in(0, Location::RegisterOrConstant(left()));
-    // Only one input can be a constant operand. The case of two constant
-    // operands should be handled by constant propagation.
-    summary->set_in(1, summary->in(0).IsConstant()
-                           ? Location::RequiresRegister()
-                           : Location::RegisterOrConstant(right()));
-    summary->set_out(Location::RequiresRegister());
-    return summary;
   }
-  LocationSummary* locs =
-      new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall);
-  // Pick arbitrary fixed input registers because this is a call.
-  locs->set_in(0, Location::RegisterLocation(EAX));
-  locs->set_in(1, Location::RegisterLocation(ECX));
-  locs->set_out(Location::RegisterLocation(EAX));
-  return locs;
+  ASSERT(operation_cid() == kSmiCid);
+  LocationSummary* summary =
+      new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
+  summary->set_in(0, Location::RegisterOrConstant(left()));
+  // Only one input can be a constant operand. The case of two constant
+  // operands should be handled by constant propagation.
+  summary->set_in(1, summary->in(0).IsConstant()
+                         ? Location::RequiresRegister()
+                         : Location::RegisterOrConstant(right()));
+  summary->set_out(Location::RequiresRegister());
+  return summary;
 }
 
 
 void RelationalOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   if (operation_cid() == kSmiCid) {
     EmitSmiComparisonOp(compiler, *locs(), kind(), NULL);
     return;
   }
   if (operation_cid() == kMintCid) {
     EmitUnboxedMintComparisonOp(compiler, *locs(), kind(), NULL);
     return;
   }
-  if (operation_cid() == kDoubleCid) {
-    EmitDoubleComparisonOp(compiler, *locs(), kind(), NULL);
-    return;
-  }
-
-  // Push arguments for the call.
-  // TODO(fschneider): Split this instruction into different types to avoid
-  // explicitly pushing arguments to the call here.
-  Register left = locs()->in(0).reg();
-  Register right = locs()->in(1).reg();
-  __ pushl(left);
-  __ pushl(right);
-  if (HasICData() && (ic_data()->NumberOfChecks() > 0)) {
-    Label* deopt = compiler->AddDeoptStub(deopt_id(), kDeoptRelationalOp);
-    // Load class into EDI. Since this is a call, any register except
-    // the fixed input registers would be ok.
-    ASSERT((left != EDI) && (right != EDI));
-    const intptr_t kNumArguments = 2;
-    LoadValueCid(compiler, EDI, left);
-    compiler->EmitTestAndCall(ICData::Handle(ic_data()->AsUnaryClassChecks()),
-                              EDI,  // Class id register.
-                              kNumArguments,
-                              Object::null_array(),  // No named arguments.
-                              deopt,  // Deoptimize target.
-                              deopt_id(),
-                              token_pos(),
-                              locs());
-    return;
-  }
-  const String& function_name =
-      String::ZoneHandle(Symbols::New(Token::Str(kind())));
-  if (!compiler->is_optimizing()) {
-    compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
-                                   deopt_id(),
-                                   token_pos());
-  }
-  const intptr_t kNumArguments = 2;
-  const intptr_t kNumArgsChecked = 2;  // Type-feedback.
-  ICData& relational_ic_data = ICData::ZoneHandle(ic_data()->raw());
-  if (compiler->is_optimizing() && FLAG_propagate_ic_data) {
-    ASSERT(!ic_data()->IsNull());
-    if (ic_data()->NumberOfChecks() == 0) {
-      // IC call for reoptimization populates original ICData.
-      relational_ic_data = ic_data()->raw();
-    } else {
-      // Megamorphic call.
-      relational_ic_data = ic_data()->AsUnaryClassChecks();
-    }
-  } else {
-    const Array& arguments_descriptor =
-        Array::Handle(ArgumentsDescriptor::New(kNumArguments,
-                                               Object::null_array()));
-    relational_ic_data = ICData::New(compiler->parsed_function().function(),
-                                     function_name,
-                                     arguments_descriptor,
-                                     deopt_id(),
-                                     kNumArgsChecked);
-  }
-  compiler->GenerateInstanceCall(deopt_id(),
-                                 token_pos(),
-                                 kNumArguments,
-                                 Object::null_array(),  // No optional args.
-                                 locs(),
-                                 relational_ic_data);
+  ASSERT(operation_cid() == kDoubleCid);
+  EmitDoubleComparisonOp(compiler, *locs(), kind(), NULL);
 }
 
 
 void RelationalOpInstr::EmitBranchCode(FlowGraphCompiler* compiler,
                                        BranchInstr* branch) {
   if (operation_cid() == kSmiCid) {
     EmitSmiComparisonOp(compiler, *locs(), kind(), branch);
     return;
   }
   if (operation_cid() == kMintCid) {
     EmitUnboxedMintComparisonOp(compiler, *locs(), kind(), branch);
     return;
   }
-  if (operation_cid() == kDoubleCid) {
-    EmitDoubleComparisonOp(compiler, *locs(), kind(), branch);
-    return;
-  }
-  EmitNativeCode(compiler);
-  __ CompareObject(EAX, Bool::True());
-  branch->EmitBranchOnCondition(compiler, EQUAL);
+  ASSERT(operation_cid() == kDoubleCid);
+  EmitDoubleComparisonOp(compiler, *locs(), kind(), branch);
 }
 
 
 LocationSummary* NativeCallInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 0;
   const intptr_t kNumTemps = 3;
   LocationSummary* locs =
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall);
   locs->set_temp(0, Location::RegisterLocation(EAX));
   locs->set_temp(1, Location::RegisterLocation(ECX));
@@ skipping 4214 matching lines @@
                          PcDescriptors::kOther,
                          locs());
   __ Drop(2);  // Discard type arguments and receiver.
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_IA32