Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: ppapi/api/pp_var.idl

Issue 23757014: [PPAPI] Updated documentation for PP_VarType enum constants. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/c/pp_var.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/api/pp_var.idl
diff --git a/ppapi/api/pp_var.idl b/ppapi/api/pp_var.idl
index fda2332b895509588ce700ab551fec8c921a3709..20b83def9cd0f7c16c51b3a2301ec239c92a9f74 100644
--- a/ppapi/api/pp_var.idl
+++ b/ppapi/api/pp_var.idl
@@ -44,7 +44,8 @@ enum PP_VarType {
/**
* The Var represents a string. The <code>as_id</code> field is used to
* identify the string, which may be created and retrieved from the
- * <code>PPB_Var</code> interface.
+ * <code>PPB_Var</code> interface. These objects are reference counted, so
yzshen1 2013/09/03 18:04:54 If you would like to mention about ref counting, a
Matt Giuca 2013/09/04 00:12:53 Done. The reason I did that was because the existi
yzshen1 2013/09/04 00:18:15 Yes, mentioning it for string/array/dictionary but
+ * AddRef and Release must be used properly to avoid memory leaks.
*/
PP_VARTYPE_STRING = 5,
@@ -55,12 +56,19 @@ enum PP_VarType {
PP_VARTYPE_OBJECT = 6,
/**
- * Arrays and dictionaries are not currently supported but will be added
- * in future revisions. These objects are reference counted so be sure
- * to properly AddRef/Release them as you would with strings to ensure your
- * module will continue to work with future versions of the API.
+ * Represents an array of Vars. The <code>as_id</code> field is used to
+ * identify the array, which may be created and manipulated from the
+ * <code>PPB_VarArray</code> interface. These objects are reference counted,
+ * so AddRef and Release must be used properly to avoid memory leaks.
*/
PP_VARTYPE_ARRAY = 7,
+
+ /**
+ * Represents a mapping from strings to Vars. The <code>as_id</code> field is
+ * used to identify the dictionary, which may be created and manipulated from
+ * the <code>PPB_VarDictionary</code> interface. These objects are reference
+ * counted, so AddRef and Release must be used properly to avoid memory leaks.
+ */
PP_VARTYPE_DICTIONARY = 8,
/**
« no previous file with comments | « no previous file | ppapi/c/pp_var.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698