Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 23757014: [PPAPI] Updated documentation for PP_VarType enum constants. (Closed)

Created:
7 years, 3 months ago by Matt Giuca
Modified:
7 years, 3 months ago
Reviewers:
raymes, yzshen1
CC:
chromium-reviews, piman+watch_chromium.org, raymes+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[PPAPI] Updated documentation for PP_VarType enum constants. Wrote proper documentation for PP_VARTYPE_ARRAY and PP_VARTYPE_DICTIONARY. These previously said that they are not currently supported, but they are. For PP_VARTYPE_STRING, added note that AddRef and Release must be used. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221654

Patch Set 1 #

Total comments: 3

Patch Set 2 : Mention refcounting in the OBJECT and ARRAY_BUFFER docs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -15 lines) Patch
M ppapi/api/pp_var.idl View 1 2 chunks +18 lines, -7 lines 0 comments Download
M ppapi/c/pp_var.h View 1 2 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Matt Giuca
7 years, 3 months ago (2013-09-03 01:55:17 UTC) #1
yzshen1
https://codereview.chromium.org/23757014/diff/1/ppapi/api/pp_var.idl File ppapi/api/pp_var.idl (right): https://codereview.chromium.org/23757014/diff/1/ppapi/api/pp_var.idl#newcode47 ppapi/api/pp_var.idl:47: * <code>PPB_Var</code> interface. These objects are reference counted, so ...
7 years, 3 months ago (2013-09-03 18:04:54 UTC) #2
Matt Giuca
https://codereview.chromium.org/23757014/diff/1/ppapi/api/pp_var.idl File ppapi/api/pp_var.idl (right): https://codereview.chromium.org/23757014/diff/1/ppapi/api/pp_var.idl#newcode47 ppapi/api/pp_var.idl:47: * <code>PPB_Var</code> interface. These objects are reference counted, so ...
7 years, 3 months ago (2013-09-04 00:12:53 UTC) #3
yzshen1
https://codereview.chromium.org/23757014/diff/1/ppapi/api/pp_var.idl File ppapi/api/pp_var.idl (right): https://codereview.chromium.org/23757014/diff/1/ppapi/api/pp_var.idl#newcode47 ppapi/api/pp_var.idl:47: * <code>PPB_Var</code> interface. These objects are reference counted, so ...
7 years, 3 months ago (2013-09-04 00:18:15 UTC) #4
Matt Giuca
Sorry, Reitveld was having a moment... It's fixed now. Do you want me to put ...
7 years, 3 months ago (2013-09-04 00:29:31 UTC) #5
yzshen1
On 2013/09/04 00:29:31, Matt Giuca wrote: > Sorry, Reitveld was having a moment... > > ...
7 years, 3 months ago (2013-09-04 07:11:00 UTC) #6
raymes
On 2013/09/04 07:11:00, yzshen1 wrote: > On 2013/09/04 00:29:31, Matt Giuca wrote: > > Sorry, ...
7 years, 3 months ago (2013-09-06 05:06:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/23757014/29001
7 years, 3 months ago (2013-09-06 05:33:38 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 08:57:30 UTC) #9
Message was sent while issue was closed.
Change committed as 221654

Powered by Google App Engine
This is Rietveld 408576698