Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: scripts/slave/recipes/chromium.py

Issue 2375663003: Add json test results format support for SwarmingIsolatedScriptTest (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium.py
diff --git a/scripts/slave/recipes/chromium.py b/scripts/slave/recipes/chromium.py
index dc683f220d496a3c871326f9137982ef38c89fc5..c3ad7984e6a8579be1d10139a98b9bfe8ae5975d 100644
--- a/scripts/slave/recipes/chromium.py
+++ b/scripts/slave/recipes/chromium.py
@@ -337,6 +337,7 @@ def GenTests(api):
)
)
+
Sergiy Byelozyorov 2016/10/05 15:36:06 nit: please remove this line... no need for double
nednguyen 2016/10/05 18:50:53 Done.
yield (
api.test('dynamic_isolated_script_test_harness_failure_zero_retcode') +
api.properties.generic(mastername='chromium.linux',
@@ -500,7 +501,41 @@ def GenTests(api):
api.test_utils.canned_isolated_script_output(
passing=True, is_win=False, swarming=True,
shards=2, isolated_script_passing=True, valid=True,
- output_chartjson=True),
+ use_json_test_format=True, output_chartjson=True),
+ retcode=0)
+ )
+
+ yield (
+ api.test('dynamic_swarmed_sharded_invalid_format_isolated_script_test') +
+ api.properties.generic(mastername='chromium.linux',
+ buildername='Linux Tests',
+ parent_buildername='Linux Builder') +
+ api.properties(swarm_hashes={
+ 'telemetry_gpu_unittests': 'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
+ }) +
+ api.platform('linux', 64) +
+ api.override_step_data(
+ 'read test spec (chromium.linux.json)',
+ api.json.output({
+ 'Linux Tests': {
+ 'isolated_scripts': [
+ {
+ 'isolate_name': 'telemetry_gpu_unittests',
+ 'name': 'telemetry_gpu_unittests',
+ 'swarming': {
+ 'can_use_on_swarming_builders': True,
+ 'shards': 3,
+ },
+ },
+ ],
+ },
+ })
+ ) +
+ api.override_step_data('telemetry_gpu_unittests on Ubuntu-12.04',
+ api.test_utils.canned_isolated_script_output(
+ passing=True, is_win=False, swarming=True,
+ shards=3, isolated_script_passing=True, valid=False,
+ use_json_test_format=True, output_chartjson=True),
retcode=0)
)
@@ -533,8 +568,8 @@ def GenTests(api):
api.override_step_data('telemetry_gpu_unittests on Ubuntu-12.04',
api.test_utils.canned_isolated_script_output(
passing=False, is_win=False, swarming=True,
- shards=2, isolated_script_passing=False, valid=True),
- retcode=1)
+ shards=2, isolated_script_passing=False, valid=True,
+ use_json_test_format=True), retcode=1)
)
yield (

Powered by Google App Engine
This is Rietveld 408576698