Replace MessageLoop::current()->task_runner() with ThreadTaskRunnerHandle::Get().

Replace MessageLoop::current()->task_runner() with ThreadTaskRunnerHandle::Get().

This CL makes the following replacements:

MessageLoop::current()->task_runner()
becomes
ThreadTaskRunnerHandle::Get()

MessageLoopForUIorIO::current()->task_runner()
becomes
DCHECK(MessageLoopForUIorIO::IsCurrent()); (or ASSERT_TRUE)
ThreadTaskRunnerHandle::Get()

TBR=gavinp@chromium.org
BUG=650723
Committed: https://crrev.com/19e49e924e88e50546ec1a81dbc7b43ea4b172ef
Cr-Commit-Position: refs/heads/master@{#422211}

[fdoray, 2016-09-27 15:06:07]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 15:06:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-09-27 15:17:45]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 15:18:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 17:09:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 17:09:23]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-09-27 17:48:33]

Description was changed from

==========
Replace MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get().

This CL makes the following replacements:

MessageLoop::current()->task_runner()
becomes
ThreadTaskRunnerHandle::Get()

MessageLoopForUIorIO::current()->task_runner()
becomes
DCHECK(MessageLoopForUIorIO::IsCurrent()); (or ASSERT_TRUE)
ThreadTaskRunnerHandle::Get()

BUG=616447
==========

to

==========
Replace MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get().

This CL makes the following replacements:

MessageLoop::current()->task_runner()
becomes
ThreadTaskRunnerHandle::Get()

MessageLoopForUIorIO::current()->task_runner()
becomes
DCHECK(MessageLoopForUIorIO::IsCurrent()); (or ASSERT_TRUE)
ThreadTaskRunnerHandle::Get()

BUG=650723
==========

[fdoray, 2016-09-27 17:57:56]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 17:58:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-09-27 19:12:49]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org

[fdoray, 2016-09-27 19:12:50]

gab@: Please take a first look.

[commit-bot: I haz the power, 2016-09-27 19:55:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 19:55:34]

Dry run: This issue passed the CQ dry run.

[gab, 2016-09-28 17:19:03]

lgtm w/ comments, woot!

https://codereview.chromium.org/2375663002/diff/40001/base/memory/ref_counted...
File base/memory/ref_counted_delete_on_message_loop.h (right):

https://codereview.chromium.org/2375663002/diff/40001/base/memory/ref_counted...
base/memory/ref_counted_delete_on_message_loop.h:36: // This constructor will
accept a MessageL00pProxy object, but new code should
MessageLoopProxy no longer exists (sadly this was probably missed in the cleanup
over a year ago which ended with http://crrev.com/335277 as someone thought it
was funny to write this with 00 ;-)).

Along with comment below I think:

// A SingleThreadTaskRunner for the current thread can be acquired by calling
ThreadTaskRunnerHandle::Get().

is a sufficient comment here, WDYT?

https://codereview.chromium.org/2375663002/diff/40001/base/memory/ref_counted...
base/memory/ref_counted_delete_on_message_loop.h:38: // MessageLoop on the
current thread can be acquired by calling
s/for the MessageLoop on the current thread/for the current thread/

https://codereview.chromium.org/2375663002/diff/40001/components/browsing_dat...
File components/browsing_data/content/conditional_cache_deletion_helper.cc
(left):

https://codereview.chromium.org/2375663002/diff/40001/components/browsing_dat...
components/browsing_data/content/conditional_cache_deletion_helper.cc:10:
#include "base/threading/thread_task_runner_handle.h"
Was surprised to not see an include change here so peaked at
conditional_cache_deletion_helper.h for fun, the include is there but it's not
used. Do we care to catch those? I guess we assume if the header has the include
it needs it for more than the usage in the .cc (it just so happens that here
IWUU is broken?)

[fdoray, 2016-09-28 18:54:50]

https://codereview.chromium.org/2375663002/diff/40001/base/memory/ref_counted...
File base/memory/ref_counted_delete_on_message_loop.h (right):

https://codereview.chromium.org/2375663002/diff/40001/base/memory/ref_counted...
base/memory/ref_counted_delete_on_message_loop.h:36: // This constructor will
accept a MessageL00pProxy object, but new code should
On 2016/09/28 17:19:03, gab wrote:
> MessageLoopProxy no longer exists (sadly this was probably missed in the
cleanup
> over a year ago which ended with http://crrev.com/335277 as someone thought it
> was funny to write this with 00 ;-)).
> 
> Along with comment below I think:
> 
> // A SingleThreadTaskRunner for the current thread can be acquired by calling
> ThreadTaskRunnerHandle::Get().
> 
> is a sufficient comment here, WDYT?

Done.

https://codereview.chromium.org/2375663002/diff/40001/base/memory/ref_counted...
base/memory/ref_counted_delete_on_message_loop.h:38: // MessageLoop on the
current thread can be acquired by calling
On 2016/09/28 17:19:03, gab wrote:
> s/for the MessageLoop on the current thread/for the current thread/

Done.

https://codereview.chromium.org/2375663002/diff/40001/components/browsing_dat...
File components/browsing_data/content/conditional_cache_deletion_helper.cc
(left):

https://codereview.chromium.org/2375663002/diff/40001/components/browsing_dat...
components/browsing_data/content/conditional_cache_deletion_helper.cc:10:
#include "base/threading/thread_task_runner_handle.h"
On 2016/09/28 17:19:03, gab wrote:
> Was surprised to not see an include change here so peaked at
> conditional_cache_deletion_helper.h for fun, the include is there but it's not
> used. Do we care to catch those? I guess we assume if the header has the
include
> it needs it for more than the usage in the .cc (it just so happens that here
> IWUU is broken?)

Hmmm... Were you talking about another file? Because thread_task_runner_handle.h
isn't included in conditional_cache_deletion_helper.h. It was already included
in this .cc file because it was already used in that file.

[fdoray, 2016-09-28 19:05:08]

fdoray@chromium.org changed reviewers:
+ dcheng@chromium.org, erg@chromium.org, estade@chromium.org,
gavinp@chromium.org, jam@chromium.org, jochen@chromium.org,
reillyg@chromium.org, sky@chromium.org, skyostil@chromium.org

[fdoray, 2016-09-28 19:05:09]

A first review of this CL was made by gab@. OWNERS: Can you LGTM changes in
directories that you own? Thanks!

sky@: ash/, chrome/, services/shell/, ui/
dcheng@: base/
jochen@: components/, content/
reillyg@: device/
jam@: ipc/
erg@: services/tracing/
skyostil@: third_party/WebKit/Source/platform/scheduler/
estade@: third_party/libaddressinput
gavinp@: third_party/zlib

[gab, 2016-09-28 19:08:12]

https://codereview.chromium.org/2375663002/diff/40001/components/browsing_dat...
File components/browsing_data/content/conditional_cache_deletion_helper.cc
(left):

https://codereview.chromium.org/2375663002/diff/40001/components/browsing_dat...
components/browsing_data/content/conditional_cache_deletion_helper.cc:10:
#include "base/threading/thread_task_runner_handle.h"
On 2016/09/28 18:54:50, fdoray wrote:
> On 2016/09/28 17:19:03, gab wrote:
> > Was surprised to not see an include change here so peaked at
> > conditional_cache_deletion_helper.h for fun, the include is there but it's
not
> > used. Do we care to catch those? I guess we assume if the header has the
> include
> > it needs it for more than the usage in the .cc (it just so happens that here
> > IWUU is broken?)
> 
> Hmmm... Were you talking about another file? Because
thread_task_runner_handle.h
> isn't included in conditional_cache_deletion_helper.h. It was already included
> in this .cc file because it was already used in that file.

Sorry, was referring to message_loop.h being included in header but not required
there. Not this CL's fault, just an incorrect include in the existing header
which I don't expect your script to catch.

[dcheng, 2016-09-28 20:12:41]

base LGTM

[Elliot Glaysher, 2016-09-28 21:58:27]

services/tracing lgtm

[Reilly Grant (use Gerrit), 2016-09-29 02:32:02]

device lgtm

[Sami, 2016-09-29 09:47:25]

third_party/WebKit/Source/platform/scheduler lgtm

[jochen (gone - plz use gerrit), 2016-09-29 12:22:02]

lgtm

[fdoray, 2016-09-29 14:49:21]

sky@: ash/, chrome/, services/shell/, ui/
dcheng@: base/ [done]
jochen@: components/, content/ [done]
reillyg@: device/ [done]
jam@: ipc/
erg@: services/tracing/ [done]
skyostil@: third_party/WebKit/Source/platform/scheduler/ [done]
estade@: third_party/libaddressinput
gavinp@: third_party/zlib

[sky, 2016-09-29 16:37:08]

LGTM

[jam, 2016-09-29 20:09:34]

lgtm

[Evan Stade, 2016-09-30 18:14:50]

On 2016/09/29 20:09:34, jam wrote:
> lgtm

[Evan Stade, 2016-09-30 18:15:35]

(don't know what happened there...)

libaddressinput lgtm, but this is a perfect example of when to use TBR

[fdoray, 2016-09-30 18:54:48]

Description was changed from

==========
Replace MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get().

This CL makes the following replacements:

MessageLoop::current()->task_runner()
becomes
ThreadTaskRunnerHandle::Get()

MessageLoopForUIorIO::current()->task_runner()
becomes
DCHECK(MessageLoopForUIorIO::IsCurrent()); (or ASSERT_TRUE)
ThreadTaskRunnerHandle::Get()

BUG=650723
==========

to

==========
Replace MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get().

This CL makes the following replacements:

MessageLoop::current()->task_runner()
becomes
ThreadTaskRunnerHandle::Get()

MessageLoopForUIorIO::current()->task_runner()
becomes
DCHECK(MessageLoopForUIorIO::IsCurrent()); (or ASSERT_TRUE)
ThreadTaskRunnerHandle::Get()

TBR=gavinp@chromium.org
BUG=650723
==========

[fdoray, 2016-09-30 18:54:48]

Description was changed from

==========
Replace MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get().

This CL makes the following replacements:

MessageLoop::current()->task_runner()
becomes
ThreadTaskRunnerHandle::Get()

MessageLoopForUIorIO::current()->task_runner()
becomes
DCHECK(MessageLoopForUIorIO::IsCurrent()); (or ASSERT_TRUE)
ThreadTaskRunnerHandle::Get()

BUG=650723
==========

to

==========
Replace MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get().

This CL makes the following replacements:

MessageLoop::current()->task_runner()
becomes
ThreadTaskRunnerHandle::Get()

MessageLoopForUIorIO::current()->task_runner()
becomes
DCHECK(MessageLoopForUIorIO::IsCurrent()); (or ASSERT_TRUE)
ThreadTaskRunnerHandle::Get()

TBR=gavinp@chromium.org
BUG=650723
==========

[fdoray, 2016-09-30 18:55:18]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-09-30 18:55:18]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
jochen@chromium.org, sky@chromium.org, jam@chromium.org, dcheng@chromium.org,
estade@chromium.org, erg@chromium.org, reillyg@chromium.org,
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2375663002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-30 18:55:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 20:42:35]

Description was changed from

==========
Replace MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get().

This CL makes the following replacements:

MessageLoop::current()->task_runner()
becomes
ThreadTaskRunnerHandle::Get()

MessageLoopForUIorIO::current()->task_runner()
becomes
DCHECK(MessageLoopForUIorIO::IsCurrent()); (or ASSERT_TRUE)
ThreadTaskRunnerHandle::Get()

TBR=gavinp@chromium.org
BUG=650723
==========

to

==========
Replace MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get().

This CL makes the following replacements:

MessageLoop::current()->task_runner()
becomes
ThreadTaskRunnerHandle::Get()

MessageLoopForUIorIO::current()->task_runner()
becomes
DCHECK(MessageLoopForUIorIO::IsCurrent()); (or ASSERT_TRUE)
ThreadTaskRunnerHandle::Get()

TBR=gavinp@chromium.org
BUG=650723
==========

[commit-bot: I haz the power, 2016-09-30 20:42:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-30 20:45:29]

Description was changed from

==========
Replace MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get().

This CL makes the following replacements:

MessageLoop::current()->task_runner()
becomes
ThreadTaskRunnerHandle::Get()

MessageLoopForUIorIO::current()->task_runner()
becomes
DCHECK(MessageLoopForUIorIO::IsCurrent()); (or ASSERT_TRUE)
ThreadTaskRunnerHandle::Get()

TBR=gavinp@chromium.org
BUG=650723
==========

to

==========
Replace MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get().

This CL makes the following replacements:

MessageLoop::current()->task_runner()
becomes
ThreadTaskRunnerHandle::Get()

MessageLoopForUIorIO::current()->task_runner()
becomes
DCHECK(MessageLoopForUIorIO::IsCurrent()); (or ASSERT_TRUE)
ThreadTaskRunnerHandle::Get()

TBR=gavinp@chromium.org
BUG=650723

Committed: https://crrev.com/19e49e924e88e50546ec1a81dbc7b43ea4b172ef
Cr-Commit-Position: refs/heads/master@{#422211}
==========

[commit-bot: I haz the power, 2016-09-30 20:45:31]

Patchset 5 (id:??) landed as
https://crrev.com/19e49e924e88e50546ec1a81dbc7b43ea4b172ef
Cr-Commit-Position: refs/heads/master@{#422211}