Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click.html

Issue 2375633002: Close the media controls overflow menu when an item is selected. (Closed)
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click.html
diff --git a/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-visibility.html b/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click.html
similarity index 78%
copy from third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-visibility.html
copy to third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click.html
index 0c19c301bc27e2ace2a0ed31f829c6be450065fa..a1e7dd610ea6d4201ef281a54e272af7643cd810 100644
--- a/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-visibility.html
+++ b/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click.html
@@ -24,19 +24,13 @@ async_test(function(t) {
var overflowList = getOverflowList(video);
var overflowMenu = getOverflowMenuButton(video);
- // Overflow menu button should be visible
- assert_not_equals(getComputedStyle(overflowMenu).display, "none");
-
- // Overflow list shouldn't be visible until it's clicked on
- assert_equals(getComputedStyle(overflowList).display, "none");
-
// Clicking on the overflow menu button should make the overflow list visible
var coords = elementCoordinates(overflowMenu);
clickAtCoordinates(coords[0], coords[1]);
assert_not_equals(getComputedStyle(overflowList).display, "none");
- // Click on the overflow menu button, again. Should close overflow list.
- var coords = elementCoordinates(overflowMenu);
+ // Click on an overflow menu item should close overflow list.
+ var coords = elementCoordinates(overflowList);
clickAtCoordinates(coords[0], coords[1]);
assert_equals(getComputedStyle(overflowList).display, "none");
});
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698