Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2375623003: Revert of Allow top-level navigation in extension pop-ups if it only triggers a download. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <utility> 10 #include <utility>
(...skipping 3328 matching lines...) Expand 10 before | Expand all | Expand 10 after
3339 FOR_EACH_OBSERVER(WebContentsObserver, observers_, 3339 FOR_EACH_OBSERVER(WebContentsObserver, observers_,
3340 DidOpenRequestedURL(new_contents, 3340 DidOpenRequestedURL(new_contents,
3341 render_frame_host, 3341 render_frame_host,
3342 params.url, 3342 params.url,
3343 params.referrer, 3343 params.referrer,
3344 params.disposition, 3344 params.disposition,
3345 params.transition)); 3345 params.transition));
3346 } 3346 }
3347 } 3347 }
3348 3348
3349 bool WebContentsImpl::ShouldTransferNavigation(bool is_main_frame_navigation) { 3349 bool WebContentsImpl::ShouldTransferNavigation() {
3350 if (!delegate_) 3350 if (!delegate_)
3351 return true; 3351 return true;
3352 return delegate_->ShouldTransferNavigation(is_main_frame_navigation); 3352 return delegate_->ShouldTransferNavigation();
3353 } 3353 }
3354 3354
3355 bool WebContentsImpl::ShouldPreserveAbortedURLs() { 3355 bool WebContentsImpl::ShouldPreserveAbortedURLs() {
3356 if (!delegate_) 3356 if (!delegate_)
3357 return false; 3357 return false;
3358 return delegate_->ShouldPreserveAbortedURLs(this); 3358 return delegate_->ShouldPreserveAbortedURLs(this);
3359 } 3359 }
3360 3360
3361 void WebContentsImpl::DidCommitProvisionalLoad( 3361 void WebContentsImpl::DidCommitProvisionalLoad(
3362 RenderFrameHostImpl* render_frame_host, 3362 RenderFrameHostImpl* render_frame_host,
(...skipping 1881 matching lines...) Expand 10 before | Expand all | Expand 10 after
5244 dialog_manager_ = dialog_manager; 5244 dialog_manager_ = dialog_manager;
5245 } 5245 }
5246 5246
5247 void WebContentsImpl::RemoveBindingSet(const std::string& interface_name) { 5247 void WebContentsImpl::RemoveBindingSet(const std::string& interface_name) {
5248 auto it = binding_sets_.find(interface_name); 5248 auto it = binding_sets_.find(interface_name);
5249 if (it != binding_sets_.end()) 5249 if (it != binding_sets_.end())
5250 binding_sets_.erase(it); 5250 binding_sets_.erase(it);
5251 } 5251 }
5252 5252
5253 } // namespace content 5253 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/public/browser/web_contents_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698