Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2375613003: Handle getters/setters and try in kernel_impact. (Closed)

Created:
4 years, 2 months ago by Johnni Winther
Modified:
4 years, 2 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -5 lines) Patch
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 5 chunks +35 lines, -4 lines 2 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 5 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 2 months ago (2016-09-27 13:17:52 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2375613003/diff/1/pkg/compiler/lib/src/ssa/kernel_impact.dart File pkg/compiler/lib/src/ssa/kernel_impact.dart (right): https://codereview.chromium.org/2375613003/diff/1/pkg/compiler/lib/src/ssa/kernel_impact.dart#newcode415 pkg/compiler/lib/src/ssa/kernel_impact.dart:415: visitNode(node.body); also visit the finalizer
4 years, 2 months ago (2016-09-27 17:12:37 UTC) #3
Johnni Winther
https://codereview.chromium.org/2375613003/diff/1/pkg/compiler/lib/src/ssa/kernel_impact.dart File pkg/compiler/lib/src/ssa/kernel_impact.dart (right): https://codereview.chromium.org/2375613003/diff/1/pkg/compiler/lib/src/ssa/kernel_impact.dart#newcode415 pkg/compiler/lib/src/ssa/kernel_impact.dart:415: visitNode(node.body); On 2016/09/27 17:12:37, Harry Terkelsen wrote: > also ...
4 years, 2 months ago (2016-09-30 07:59:04 UTC) #4
Johnni Winther
4 years, 2 months ago (2016-09-30 08:03:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3fb04e34951d9e0c5f0a39b34c45a753ca435676 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698