Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4754)

Unified Diff: chrome/test/chromedriver/chrome/device_manager.cc

Issue 2375613002: Fix Chromedriver Issue 749
Patch Set: Bug Fix for chromedriver issue 749 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/device_manager.cc
diff --git a/chrome/test/chromedriver/chrome/device_manager.cc b/chrome/test/chromedriver/chrome/device_manager.cc
index f4705a7a7e2418fb2a2333385ef54984940694ee..a413081ec63d7068ecaa67b59b23661139f682f9 100644
--- a/chrome/test/chromedriver/chrome/device_manager.cc
+++ b/chrome/test/chromedriver/chrome/device_manager.cc
@@ -120,17 +120,15 @@ Status Device::ForwardDevtoolsPort(const std::string& package,
std::string* device_socket) {
if (device_socket->empty()) {
// Assume this is a WebView app.
- int pid;
- Status status = adb_->GetPidByName(serial_,
- process.empty() ? package : process,
- &pid);
+ Status status = adb_->GetDevtoolsRemoteSocket(serial_,
+ process.empty() ? package :
+ process, device_socket);
if (status.IsError()) {
if (process.empty())
status.AddDetails(
"process name must be specified if not equal to package name");
return status;
}
- *device_socket = base::StringPrintf("webview_devtools_remote_%d", pid);
}
return adb_->ForwardPort(serial_, port, *device_socket);

Powered by Google App Engine
This is Rietveld 408576698