Fix Chromedriver Issue 749

chrome/test/chromedriver/chrome/device_manager.cc

Index: chrome/test/chromedriver/chrome/device_manager.cc
diff --git a/chrome/test/chromedriver/chrome/device_manager.cc b/chrome/test/chromedriver/chrome/device_manager.cc
index f4705a7a7e2418fb2a2333385ef54984940694ee..68ab60786ee1481fc0c2408643107da35b5ed445 100644
--- a/chrome/test/chromedriver/chrome/device_manager.cc
+++ b/chrome/test/chromedriver/chrome/device_manager.cc
@@ -120,17 +120,16 @@ Status Device::ForwardDevtoolsPort(const std::string& package,
                                    std::string* device_socket) {
   if (device_socket->empty()) {
     // Assume this is a WebView app.
-    int pid;
-    Status status = adb_->GetPidByName(serial_,
+    Status status = adb_->GetDevtoolsRemoteSocket(serial_,
                                        process.empty() ? package : process,
-                                       &pid);
+                                       device_socket);

[samuong, 2016/10/03 18:50:40]

reindent so that all arguments are aligned

[Rahul Kavalapara, 2016/10/05 08:06:42]

Done.

     if (status.IsError()) {
       if (process.empty())
         status.AddDetails(
             "process name must be specified if not equal to package name");
       return status;
     }
-    *device_socket = base::StringPrintf("webview_devtools_remote_%d", pid);
+    // *device_socket = base::StringPrintf("webview_devtools_remote_%d", pid);

[samuong, 2016/10/03 18:50:40]

don't uncomment, just delete this line

[Rahul Kavalapara, 2016/10/05 08:06:42]

Done.

   }
 
   return adb_->ForwardPort(serial_, port, *device_socket);