Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: chrome/test/chromedriver/chrome/adb.h

Issue 2375613002: Fix Chromedriver Issue 749
Patch Set: Fix for chromedriver issue 749 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/adb.h
diff --git a/chrome/test/chromedriver/chrome/adb.h b/chrome/test/chromedriver/chrome/adb.h
index 47c8b1f56099560075b5b008ae25e08f565a64f5..b8adbe172070cc1c0b152c8f8868523dd4cd067a 100644
--- a/chrome/test/chromedriver/chrome/adb.h
+++ b/chrome/test/chromedriver/chrome/adb.h
@@ -33,9 +33,13 @@ class Adb {
const std::string& activity) = 0;
virtual Status ForceStop(const std::string& device_serial,
const std::string& package) = 0;
+ virtual Status GetDevtoolsRemoteSocket(const std::string& device_serial,
+ const std::string& process_name,
+ std::string* device_socket) = 0;
samuong 2016/10/03 18:50:40 indent lines 37-38 so that they line up with the f
Rahul Kavalapara 2016/10/05 08:06:42 Done.
virtual Status GetPidByName(const std::string& device_serial,
const std::string& process_name,
int* pid) = 0;
+
samuong 2016/10/03 18:50:40 don't add a blank line here
Rahul Kavalapara 2016/10/05 08:06:42 Done.
};
#endif // CHROME_TEST_CHROMEDRIVER_CHROME_ADB_H_

Powered by Google App Engine
This is Rietveld 408576698