Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Side by Side Diff: chrome/test/chromedriver/chrome/device_manager_unittest.cc

Issue 2375613002: Fix Chromedriver Issue 749
Patch Set: Fix for chromedriver issue 749 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/chromedriver/chrome/device_manager.h" 5 #include "chrome/test/chromedriver/chrome/device_manager.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 const std::string& package, 58 const std::string& package,
59 const std::string& activity) override { 59 const std::string& activity) override {
60 return Status(kOk); 60 return Status(kOk);
61 } 61 }
62 62
63 Status ForceStop(const std::string& device_serial, 63 Status ForceStop(const std::string& device_serial,
64 const std::string& package) override { 64 const std::string& package) override {
65 return Status(kOk); 65 return Status(kOk);
66 } 66 }
67 67
68 Status GetDevtoolsRemoteSocket(const std::string& device_serial,
69 const std::string& process_name,
70 std::string* device_socket) override {
samuong 2016/10/03 18:50:40 reindent so that function parameters are aligned
71 *device_socket = "webview_devtools_remote_123";
72 return Status(kOk);
73 }
74
68 Status GetPidByName(const std::string& device_serial, 75 Status GetPidByName(const std::string& device_serial,
69 const std::string& process_name, 76 const std::string& process_name,
70 int* pid) override { 77 int* pid) override {
71 *pid = 0; // avoid uninit error crbug.com/393231 78 *pid = 0; // avoid uninit error crbug.com/393231
72 return Status(kOk); 79 return Status(kOk);
73 } 80 }
74 }; 81 };
75 82
76 } // namespace 83 } // namespace
77 84
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 "a.chrome.package", "an.activity", "", "", false, 0).IsOk()); 124 "a.chrome.package", "an.activity", "", "", false, 0).IsOk());
118 ASSERT_FALSE(device1->SetUp("a.package", "", "", "", false, 0).IsOk()); 125 ASSERT_FALSE(device1->SetUp("a.package", "", "", "", false, 0).IsOk());
119 ASSERT_TRUE(device1->SetUp( 126 ASSERT_TRUE(device1->SetUp(
120 "a.package", "an.activity", "", "", false, 0).IsOk()); 127 "a.package", "an.activity", "", "", false, 0).IsOk());
121 ASSERT_TRUE(device1->TearDown().IsOk()); 128 ASSERT_TRUE(device1->TearDown().IsOk());
122 ASSERT_TRUE(device1->TearDown().IsOk()); 129 ASSERT_TRUE(device1->TearDown().IsOk());
123 ASSERT_TRUE(device1->SetUp( 130 ASSERT_TRUE(device1->SetUp(
124 "a.package", "an.activity", "a.process", "", false, 0).IsOk()); 131 "a.package", "an.activity", "a.process", "", false, 0).IsOk());
125 ASSERT_TRUE(device1->TearDown().IsOk()); 132 ASSERT_TRUE(device1->TearDown().IsOk());
126 } 133 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698