Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: chrome/test/chromedriver/chrome/adb_impl.h

Issue 2375613002: Fix Chromedriver Issue 749
Patch Set: Fix for chromedriver issue 749 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TEST_CHROMEDRIVER_CHROME_ADB_IMPL_H_ 5 #ifndef CHROME_TEST_CHROMEDRIVER_CHROME_ADB_IMPL_H_
6 #define CHROME_TEST_CHROMEDRIVER_CHROME_ADB_IMPL_H_ 6 #define CHROME_TEST_CHROMEDRIVER_CHROME_ADB_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 27 matching lines...) Expand all
38 const std::string& package) override; 38 const std::string& package) override;
39 Status ClearAppData(const std::string& device_serial, 39 Status ClearAppData(const std::string& device_serial,
40 const std::string& package) override; 40 const std::string& package) override;
41 Status SetDebugApp(const std::string& device_serial, 41 Status SetDebugApp(const std::string& device_serial,
42 const std::string& package) override; 42 const std::string& package) override;
43 Status Launch(const std::string& device_serial, 43 Status Launch(const std::string& device_serial,
44 const std::string& package, 44 const std::string& package,
45 const std::string& activity) override; 45 const std::string& activity) override;
46 Status ForceStop(const std::string& device_serial, 46 Status ForceStop(const std::string& device_serial,
47 const std::string& package) override; 47 const std::string& package) override;
48 Status GetDevtoolsRemoteSocket(const std::string& device_serial,
49 const std::string& process_name,
50 std::string* device_socket) override;
48 Status GetPidByName(const std::string& device_serial, 51 Status GetPidByName(const std::string& device_serial,
49 const std::string& process_name, 52 const std::string& process_name,
50 int* pid) override; 53 int* pid) override;
51 54
55
samuong 2016/10/03 18:50:40 don't add a blank line here
Rahul Kavalapara 2016/10/05 08:06:42 Done.
52 private: 56 private:
53 Status ExecuteCommand(const std::string& command, 57 Status ExecuteCommand(const std::string& command,
54 std::string* response); 58 std::string* response);
55 Status ExecuteHostCommand(const std::string& device_serial, 59 Status ExecuteHostCommand(const std::string& device_serial,
56 const std::string& host_command, 60 const std::string& host_command,
57 std::string* response); 61 std::string* response);
58 Status ExecuteHostShellCommand(const std::string& device_serial, 62 Status ExecuteHostShellCommand(const std::string& device_serial,
59 const std::string& shell_command, 63 const std::string& shell_command,
60 std::string* response); 64 std::string* response);
61 65
62 scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_; 66 scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
63 67
64 int port_; 68 int port_;
65 }; 69 };
66 70
67 #endif // CHROME_TEST_CHROMEDRIVER_CHROME_ADB_IMPL_H_ 71 #endif // CHROME_TEST_CHROMEDRIVER_CHROME_ADB_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698