[rac] Show amex specific cvc hint

chrome/browser/ui/views/autofill/autofill_dialog_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 2000 matching lines @@
        iter != updated_inputs.end(); ++iter) {
     const DetailInput& input = *iter;
     TextfieldMap::iterator text_mapping = group->textfields.find(&input);
 
     if (text_mapping != group->textfields.end()) {
       DecoratedTextfield* decorated = text_mapping->second;
       decorated->SetEnabled(input.editable);
       if (decorated->text().empty() || clobber_inputs) {
         decorated->SetText(iter->initial_value);
         decorated->SetIcon(
             delegate_->IconForField(input.type, decorated->text()));

[Evan Stade, 2013/09/11 00:17:03]

I don't think this will work any more.

       }
     }
 
     ComboboxMap::iterator combo_mapping = group->comboboxes.find(&input);
     if (combo_mapping != group->comboboxes.end()) {
       views::Combobox* combobox = combo_mapping->second;
       combobox->SetEnabled(input.editable);
       if (combobox->selected_index() == combobox->model()->GetDefaultIndex() ||
           clobber_inputs) {
         for (int i = 0; i < combobox->model()->GetItemCount(); ++i) {
@@ skipping 217 matching lines @@
 
   // If the field is marked as invalid, check if the text is now valid.
   // Many fields (i.e. CC#) are invalid for most of the duration of editing,
   // so flagging them as invalid prematurely is not helpful. However,
   // correcting a minor mistake (i.e. a wrong CC digit) should immediately
   // result in validation - positive user feedback.
   if (decorated->invalid() && was_edit) {
     SetValidityForInput<DecoratedTextfield>(
         decorated,
         delegate_->InputValidityMessage(group->section, type,
-                                          textfield->text()));
+                                        textfield->text()));
 
     // If the field transitioned from invalid to valid, re-validate the group,
     // since inter-field checks become meaningful with valid fields.
     if (!decorated->invalid())
       ValidateGroup(*group, VALIDATE_EDIT);
   }
 
-  gfx::Image icon = delegate_->IconForField(type, textfield->text());
-  decorated->SetIcon(icon);
+  if (!delegate_->IsIconDependentField(type))
+    decorated->SetIcon(delegate_->IconForField(type, textfield->text()));
+
+  ServerFieldType dependent_type = UNKNOWN_TYPE;
+  if (delegate_->IsIconDependencyField(type, &dependent_type)) {
+    DecoratedTextfield* dependent_field =
+        DecoratedTextfieldForServerFieldType(group, dependent_type);
+    if (dependent_field) {
+      dependent_field->SetIcon(
+          delegate_->IconForField(dependent_type, textfield->text()));

[Evan Stade, 2013/09/11 00:17:03]

API abuse! you're passing a type and a textval that don't match up.

[please use gerrit instead, 2013/09/11 16:27:40]

How about adding an API call "IconForDependentField(depdendent_type,
dependency_value)" ?

+    }
+  }
 }
 
 void AutofillDialogViews::UpdateButtonStripExtraView() {
   save_in_chrome_checkbox_container_->SetVisible(
       delegate_->ShouldOfferToSaveInChrome());
 
   gfx::Image image = delegate_->ButtonStripImage();
   button_strip_image_->SetVisible(!image.IsEmpty());
   button_strip_image_->SetImage(image.AsImageSkia());
 }
@@ skipping 67 matching lines @@
   }
 
   return NULL;
 }
 
 void AutofillDialogViews::DetailsContainerBoundsChanged() {
   if (error_bubble_)
     error_bubble_->UpdatePosition();
 }
 
+DecoratedTextfield* AutofillDialogViews::DecoratedTextfieldForServerFieldType(
+    const DetailsGroup* group,
+    ServerFieldType type) const {
+  for (TextfieldMap::const_iterator field_iter = group->textfields.begin();
+       field_iter != group->textfields.end();
+       ++field_iter) {
+    if (field_iter->first->type == type)
+      return field_iter->second;
+  }
+
+  return NULL;
+}
+
 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section)
     : section(section),
       container(NULL),
       manual_input(NULL),
       suggested_info(NULL),
       suggested_button(NULL) {}
 
 AutofillDialogViews::DetailsGroup::~DetailsGroup() {}
 
 }  // namespace autofill