Allow inlining of methods that have an intrinsic translation.

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
 #include "vm/dart_entry.h"
 #include "vm/flow_graph_builder.h"
@@ skipping 1390 matching lines @@
     // Reset value types if guarded_cid was used.
     for (Value::Iterator it(load->input_use_list());
          !it.Done();
          it.Advance()) {
       it.Current()->SetReachingType(NULL);
     }
   }
 }
 
 
-void FlowGraphOptimizer::InlineGrowableArrayCapacityGetter(
-    InstanceCallInstr* call) {
-  AddReceiverCheck(call);
-
-  // TODO(srdjan): type of load should be GrowableObjectArrayType.
-  LoadFieldInstr* data_load = new LoadFieldInstr(
-      new Value(call->ArgumentAt(0)),
-      Array::data_offset(),
-      Type::ZoneHandle(Type::DynamicType()));
-  data_load->set_result_cid(kArrayCid);
-  InsertBefore(call, data_load, NULL, Definition::kValue);
-
-  LoadFieldInstr* length_load = new LoadFieldInstr(
-      new Value(data_load),
-      Array::length_offset(),
-      Type::ZoneHandle(Type::SmiType()));
-  length_load->set_result_cid(kSmiCid);
-  length_load->set_recognized_kind(MethodRecognizer::kObjectArrayLength);
-
-  ReplaceCall(call, length_load);
-}
-
-
 static LoadFieldInstr* BuildLoadStringLength(Definition* str) {
   // Treat length loads as mutable (i.e. affected by side effects) to avoid
   // hoisting them since we can't hoist the preceding class-check. This
   // is because of externalization of strings that affects their class-id.
   const bool is_immutable = false;
   LoadFieldInstr* load = new LoadFieldInstr(
       new Value(str),
       String::length_offset(),
       Type::ZoneHandle(Type::SmiType()),
       is_immutable);
   load->set_result_cid(kSmiCid);
   load->set_recognized_kind(MethodRecognizer::kStringBaseLength);
   return load;
 }
 
 
-void FlowGraphOptimizer::InlineStringIsEmptyGetter(InstanceCallInstr* call) {
-  AddReceiverCheck(call);
-
-  LoadFieldInstr* load = BuildLoadStringLength(call->ArgumentAt(0));
-  InsertBefore(call, load, NULL, Definition::kValue);
-
-  ConstantInstr* zero = flow_graph()->GetConstant(Smi::Handle(Smi::New(0)));
-  StrictCompareInstr* compare =
-      new StrictCompareInstr(call->token_pos(),
-                             Token::kEQ_STRICT,
-                             new Value(load),
-                             new Value(zero));
-  ReplaceCall(call, compare);
-}
-
-
-void FlowGraphOptimizer::InlineObjectCid(InstanceCallInstr* call) {
-  LoadClassIdInstr* load = new LoadClassIdInstr(new Value(call->ArgumentAt(0)));
-  ReplaceCall(call, load);
-}
-
-
 bool FlowGraphOptimizer::InlineFloat32x4Getter(InstanceCallInstr* call,
                                                MethodRecognizer::Kind getter) {
   if (!ShouldInlineSimd()) {
     return false;
   }
   AddCheckClass(call->ArgumentAt(0),
                 ICData::ZoneHandle(
                     call->ic_data()->AsUnaryClassChecksForArgNr(0)),
                 call->deopt_id(),
                 call->env(),
@@ skipping 160 matching lines @@
   } else if (target.kind() == RawFunction::kNoSuchMethodDispatcher) {
     return false;
   }
 
   // Not an implicit getter.
   MethodRecognizer::Kind recognized_kind =
       MethodRecognizer::RecognizeKind(target);
 
   // VM objects length getter.
   switch (recognized_kind) {
-    case MethodRecognizer::kObjectCid: {
-      InlineObjectCid(call);
-      return true;
-    }
-    case MethodRecognizer::kGrowableArrayCapacity:
-      InlineGrowableArrayCapacityGetter(call);
-      return true;
-    case MethodRecognizer::kStringBaseIsEmpty:
-      if (!ic_data.HasOneTarget()) {
-        // Target is not only StringBase_get_isEmpty.
-        return false;
-      }
-      InlineStringIsEmptyGetter(call);
-      return true;
     case MethodRecognizer::kFloat32x4ShuffleX:
     case MethodRecognizer::kFloat32x4ShuffleY:
     case MethodRecognizer::kFloat32x4ShuffleZ:
     case MethodRecognizer::kFloat32x4ShuffleW:
     case MethodRecognizer::kFloat32x4GetSignMask:
       if (!ic_data.HasReceiverClassId(kFloat32x4Cid) ||
           !ic_data.HasOneTarget()) {
         return false;
       }
       return InlineFloat32x4Getter(call, recognized_kind);
@@ skipping 5858 matching lines @@
   }
 
   // Insert materializations at environment uses.
   for (intptr_t i = 0; i < exits.length(); i++) {
     CreateMaterializationAt(exits[i], alloc, alloc->cls(), *fields);
   }
 }
 
 
 }  // namespace dart