Fix compile error for MacOSX10.11.sdk using static_cast<CGEventFlags>

Fix compile error for MacOSX10.11.sdk using static_cast<CGEventFlags>

This CL fixes following error.

../../ui/events/test/cocoa_test_event_utils.mm:156:3: error: no matching function for call to 'CGEventSetFlags'
  CGEventSetFlags(scroll, 0);
  ^~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEvent.h:175:16: note: candidate function not viable: no known conversion from 'int' to 'CGEventFlags' for 2nd argument
CG_EXTERN void CGEventSetFlags(CGEventRef __nullable event, CGEventFlags flags)
               ^
1 error generated.

TBR=avi@chromium.org
BUG=

Committed: https://crrev.com/0ca7dfeb300b064706448a8d02bea8229cf815e1
Cr-Commit-Position: refs/heads/master@{#421134}

[tikuta, 2016-09-27 05:45:25]

tikuta@chromium.org changed reviewers:
+ avi@chromium.org, sky@chromium.org, tapted@chromium.org

[tikuta, 2016-09-27 05:45:25]

This is small fix for MacOSX10.11 SDK.

Please review this.

[tapted, 2016-09-27 06:40:16]

dang it - too many SDKs.... lgtm with the below - thanks!

And I would TBR avi and CQ - it's important this gets in to avoid disrupting
others'

https://codereview.chromium.org/2375593002/diff/1/ui/events/test/cocoa_test_e...
File ui/events/test/cocoa_test_event_utils.mm (right):

https://codereview.chromium.org/2375593002/diff/1/ui/events/test/cocoa_test_e...
ui/events/test/cocoa_test_event_utils.mm:156: CGEventSetFlags(scroll,
static_cast<CGEventFlags>(kCGEventNull));
kCGEventNull -> 0

kCGEventNull is a CGEventType (32-bit enum) not a CGEventFlags (64-bit bitmask)
- bizarrely the new SDK doesn't provide a constant for 0

[tikuta, 2016-09-27 06:47:31]

Description was changed from

==========
Fix compile error for MacOSX10.11.sdk using static_cast<CGEventFlags>

This CL fixes following error.

../../ui/events/test/cocoa_test_event_utils.mm:156:3: error: no matching
function for call to 'CGEventSetFlags'
  CGEventSetFlags(scroll, 0);
  ^~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEvent.h:175:16:
note: candidate function not viable: no known conversion from 'int' to
'CGEventFlags' for 2nd argument
CG_EXTERN void CGEventSetFlags(CGEventRef __nullable event, CGEventFlags flags)
               ^
1 error generated.

BUG=
==========

to

==========
Fix compile error for MacOSX10.11.sdk using static_cast<CGEventFlags>

This CL fixes following error.

../../ui/events/test/cocoa_test_event_utils.mm:156:3: error: no matching
function for call to 'CGEventSetFlags'
  CGEventSetFlags(scroll, 0);
  ^~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEvent.h:175:16:
note: candidate function not viable: no known conversion from 'int' to
'CGEventFlags' for 2nd argument
CG_EXTERN void CGEventSetFlags(CGEventRef __nullable event, CGEventFlags flags)
               ^
1 error generated.

TBR=avi@chromium.org
BUG=
==========

[tikuta, 2016-09-27 06:49:03]

Thank you for review.
I commit this with TBR.

https://codereview.chromium.org/2375593002/diff/1/ui/events/test/cocoa_test_e...
File ui/events/test/cocoa_test_event_utils.mm (right):

https://codereview.chromium.org/2375593002/diff/1/ui/events/test/cocoa_test_e...
ui/events/test/cocoa_test_event_utils.mm:156: CGEventSetFlags(scroll,
static_cast<CGEventFlags>(kCGEventNull));
On 2016/09/27 06:40:16, tapted wrote:
> kCGEventNull -> 0
> 
> kCGEventNull is a CGEventType (32-bit enum) not a CGEventFlags (64-bit
bitmask)
> - bizarrely the new SDK doesn't provide a constant for 0

Done.

[tikuta, 2016-09-27 06:49:19]

The CQ bit was checked by tikuta@chromium.org

[tikuta, 2016-09-27 06:49:19]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2375593002/#ps20001
(title: "use constant 0")

[commit-bot: I haz the power, 2016-09-27 06:49:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 07:16:02]

Description was changed from

==========
Fix compile error for MacOSX10.11.sdk using static_cast<CGEventFlags>

This CL fixes following error.

../../ui/events/test/cocoa_test_event_utils.mm:156:3: error: no matching
function for call to 'CGEventSetFlags'
  CGEventSetFlags(scroll, 0);
  ^~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEvent.h:175:16:
note: candidate function not viable: no known conversion from 'int' to
'CGEventFlags' for 2nd argument
CG_EXTERN void CGEventSetFlags(CGEventRef __nullable event, CGEventFlags flags)
               ^
1 error generated.

TBR=avi@chromium.org
BUG=
==========

to

==========
Fix compile error for MacOSX10.11.sdk using static_cast<CGEventFlags>

This CL fixes following error.

../../ui/events/test/cocoa_test_event_utils.mm:156:3: error: no matching
function for call to 'CGEventSetFlags'
  CGEventSetFlags(scroll, 0);
  ^~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEvent.h:175:16:
note: candidate function not viable: no known conversion from 'int' to
'CGEventFlags' for 2nd argument
CG_EXTERN void CGEventSetFlags(CGEventRef __nullable event, CGEventFlags flags)
               ^
1 error generated.

TBR=avi@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-09-27 07:16:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-27 07:18:30]

Description was changed from

==========
Fix compile error for MacOSX10.11.sdk using static_cast<CGEventFlags>

This CL fixes following error.

../../ui/events/test/cocoa_test_event_utils.mm:156:3: error: no matching
function for call to 'CGEventSetFlags'
  CGEventSetFlags(scroll, 0);
  ^~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEvent.h:175:16:
note: candidate function not viable: no known conversion from 'int' to
'CGEventFlags' for 2nd argument
CG_EXTERN void CGEventSetFlags(CGEventRef __nullable event, CGEventFlags flags)
               ^
1 error generated.

TBR=avi@chromium.org
BUG=
==========

to

==========
Fix compile error for MacOSX10.11.sdk using static_cast<CGEventFlags>

This CL fixes following error.

../../ui/events/test/cocoa_test_event_utils.mm:156:3: error: no matching
function for call to 'CGEventSetFlags'
  CGEventSetFlags(scroll, 0);
  ^~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEvent.h:175:16:
note: candidate function not viable: no known conversion from 'int' to
'CGEventFlags' for 2nd argument
CG_EXTERN void CGEventSetFlags(CGEventRef __nullable event, CGEventFlags flags)
               ^
1 error generated.

TBR=avi@chromium.org
BUG=

Committed: https://crrev.com/0ca7dfeb300b064706448a8d02bea8229cf815e1
Cr-Commit-Position: refs/heads/master@{#421134}
==========

[commit-bot: I haz the power, 2016-09-27 07:18:31]

Patchset 2 (id:??) landed as
https://crrev.com/0ca7dfeb300b064706448a8d02bea8229cf815e1
Cr-Commit-Position: refs/heads/master@{#421134}

[Avi (use Gerrit), 2016-09-27 15:22:46]

lgtm