Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2375583004: [HBD] Add flag in about:flags for PPS on ALLOW mode. (Closed)

Created:
4 years, 2 months ago by tommycli
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jam, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[HBD] Add flag in about:flags for PPS on ALLOW mode. BUG=649814 Committed: https://crrev.com/d8fdfd15f52db85601307b0f2db6e2ef45d9f686 Cr-Commit-Position: refs/heads/master@{#421864}

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/chrome_features.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
tommycli
bauerb: PTAL, thanks! (see bug for ui design discussion)
4 years, 2 months ago (2016-09-28 22:00:41 UTC) #4
Bernhard Bauer
lgtm
4 years, 2 months ago (2016-09-29 08:34:50 UTC) #11
tommycli
bauerb: thanks!
4 years, 2 months ago (2016-09-29 16:41:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375583004/40001
4 years, 2 months ago (2016-09-29 16:41:31 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/269692)
4 years, 2 months ago (2016-09-29 16:51:45 UTC) #16
Alexei Svitkine (slow)
lgtm
4 years, 2 months ago (2016-09-29 16:53:55 UTC) #18
tommycli
thanks all!
4 years, 2 months ago (2016-09-29 17:34:56 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375583004/40001
4 years, 2 months ago (2016-09-29 17:35:38 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-29 17:41:59 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 17:46:52 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d8fdfd15f52db85601307b0f2db6e2ef45d9f686
Cr-Commit-Position: refs/heads/master@{#421864}

Powered by Google App Engine
This is Rietveld 408576698