Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2375583002:
clean up replace contents()->GetMainFrame() to main_test_rfh() (Closed)
Descriptionclean up replace contents()->GetMainFrame() to main_test_rfh()
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/721f96a79d8dbb6ab8ab3d4ae45f2219da100412
Cr-Commit-Position: refs/heads/master@{#421303}
Patch Set 1 #Patch Set 2 : reindent #Patch Set 3 : clean up replace contents()->GetMainFrame() to main_test_rfh() #Patch Set 4 : clean up replace contents()->GetMainFrame() to main_test_rfh() #Patch Set 5 : clean up replace contents()->GetMainFrame() to main_test_rfh() #Patch Set 6 : clean up replace contents()->GetMainFrame() to main_test_rfh() #
Total comments: 1
Messages
Total messages: 34 (23 generated)
Description was changed from ========== clean up replace contents()->GetMainFrame() to main_test_rfh() ========== to ========== clean up replace contents()->GetMainFrame() to main_test_rfh() CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== clean up replace contents()->GetMainFrame() to main_test_rfh() CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== clean up replace contents()->GetMainFrame() to main_test_rfh() CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
corona10@gmail.com changed reviewers: + jinho.bang@samsung.com
corona10@gmail.com changed reviewers: + nick@chromium.org
PTAL
The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
corona10@gmail.com changed reviewers: - nick@chromium.org
corona10@gmail.com changed reviewers: + nick@chromium.org
The CQ bit was checked by simonhong@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
corona10@gmail.com changed reviewers: - nick@chromium.org
The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
corona10@gmail.com changed reviewers: + nick@chromium.org
@ncarter PTAL
The CQ bit was checked by nick@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== clean up replace contents()->GetMainFrame() to main_test_rfh() CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== clean up replace contents()->GetMainFrame() to main_test_rfh() CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== clean up replace contents()->GetMainFrame() to main_test_rfh() CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== clean up replace contents()->GetMainFrame() to main_test_rfh() CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/721f96a79d8dbb6ab8ab3d4ae45f2219da100412 Cr-Commit-Position: refs/heads/master@{#421303} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/721f96a79d8dbb6ab8ab3d4ae45f2219da100412 Cr-Commit-Position: refs/heads/master@{#421303}
Message was sent while issue was closed.
This broke the PlzNavigate tests: https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigatio... Revert in meantime?
Message was sent while issue was closed.
On 2016/09/27 20:46:08, jam wrote: > This broke the PlzNavigate tests: > https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigatio... > > Revert in meantime? I'll revert.
Message was sent while issue was closed.
https://codereview.chromium.org/2375583002/diff/100001/content/browser/web_co... File content/browser/web_contents/web_contents_impl_unittest.cc (right): https://codereview.chromium.org/2375583002/diff/100001/content/browser/web_co... content/browser/web_contents/web_contents_impl_unittest.cc:2937: main_test_rfh()->PrepareForCommit(); Oh yeah, this isn't safe at all.
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2366333004/ by nick@chromium.org. The reason for reverting is: This patch is incorrect. |contents| and |contents()| are different objects.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
