Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2375553002: Remove unused macros for msa. (Closed)

Created:
4 years, 2 months ago by fbarchard1
Modified:
4 years, 2 months ago
Reviewers:
manojkumar.bhosale
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Remove unused macros for msa. Signed vectors are rarely used in libyuv... remove macros for now. Remove word shuffler, use byte shuffler in row_msa. Bump version number. TBR=manojkumar.bhosale@imgtec.com BUG=libyuv:634 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/51a3500c1894387e94d81f193de571475d57d6d0

Patch Set 1 #

Patch Set 2 : guard fix for lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -25 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/macros_msa.h View 1 4 chunks +6 lines, -23 lines 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
fbarchard1
4 years, 2 months ago (2016-09-26 23:44:35 UTC) #1
fbarchard1
guard has wrong name. git cl lint include/libyuv/macros_msa.h:11: #ifndef header guard has wrong style, please ...
4 years, 2 months ago (2016-09-26 23:49:23 UTC) #2
fbarchard1
trybots fails gyp: name 'mips_msa' is not defined while evaluating condition '(target_arch == "mipsel" or ...
4 years, 2 months ago (2016-09-27 00:00:53 UTC) #3
fbarchard1
4 years, 2 months ago (2016-09-27 00:35:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
51a3500c1894387e94d81f193de571475d57d6d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698